fix(build-plugin-alt): babelPluginMeta 对 package 中一部分 meta 未定义的情况处理错误

eternalsky · eternalsky · commit aa5fef0b9728 · 2022-12-23T15:14:33.000+08:00
diff --git a/packages/build-plugin-alt/CHANGELOG.md b/packages/build-plugin-alt/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 1.3.0
 
 - `feat` 新增配置项 usePrivateIp，为 true 时 injectInfo 使用 private ip 而非 local ip。
+- `fix` babelPluginMeta 对 package 中一部分 meta 未定义的情况处理错误
 
 ## 1.2.2
 
diff --git a/packages/build-plugin-alt/package.json b/packages/build-plugin-alt/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@alilc/build-plugin-alt",
-  "version": "1.3.0-beta.0",
+  "version": "1.3.0",
   "description": "build-scripts plugin template for developers",
   "main": "lib/index.js",
   "files": [
diff --git a/packages/build-plugin-alt/src/babelPluginMeta.ts b/packages/build-plugin-alt/src/babelPluginMeta.ts
@@ -11,7 +11,7 @@ interface IMeta {
 interface IVisitorPass {
   opts?: {
     filename: string;
-    meta: IMeta;
+    meta?: IMeta;
   }
   filename?: string;
 }
@@ -40,22 +40,22 @@ const injectMetaVisitor: Visitor<IInjectVisitorPass> = {
         (BabelTypes.isStringLiteral(property) && property.value === 'pluginName')
       ) {
         const meta = pass.meta;
-        if (meta.pluginName) {
+        pass.cache.pluginNameAssignmentExists = true;
+        if (meta?.pluginName) {
           path.node.right = BabelTypes.stringLiteral(meta.pluginName);
           addInfoComment(path.node);
-          pass.cache.pluginNameAssignmentExists = true;
         }
       }
       if (
         (BabelTypes.isIdentifier(property) && property.name === 'meta') ||
         (BabelTypes.isStringLiteral(property) && property.value === 'meta')
       ) {
         const meta = pass.meta;
-        if (meta.meta) {
+        pass.cache.metaAssignmentExists = true;
+        if (meta?.meta) {
           const generateAst = template(`const a = ${JSON.stringify(meta.meta)}`)() as BabelTypes.VariableDeclaration;
           path.node.right = generateAst.declarations[0].init;
           addInfoComment(path.node);
-          pass.cache.metaAssignmentExists = true;
         }
       }
     }
@@ -78,13 +78,13 @@ export default function (babel: { types: typeof BabelTypes }): {
         if (t.isIdentifier(path.node.declaration)) {
           const declarationName = path.node.declaration.name;
           path.parentPath.traverse(injectMetaVisitor, { ...state.opts, declarationName, cache })
-          if (!cache.pluginNameAssignmentExists) {
-            const generatedNode  = template(`${declarationName}.pluginName = "${state.opts.meta.pluginName}"`)();
+          if (!cache.pluginNameAssignmentExists && state.opts?.meta?.pluginName) {
+            const generatedNode  = template(`${declarationName}.pluginName = "${state.opts?.meta?.pluginName}"`)();
             addInfoComment(generatedNode);
             path.insertBefore(generatedNode);
           }
-          if (!cache.metaAssignmentExists) {
-            const generatedNode = template(`${declarationName}.meta = ${JSON.stringify(state.opts.meta.meta)}`)();
+          if (!cache.metaAssignmentExists && state.opts?.meta?.meta) {
+            const generatedNode = template(`${declarationName}.meta = ${JSON.stringify(state.opts?.meta?.meta)}`)();
             addInfoComment(generatedNode);
             path.insertBefore(generatedNode);
           }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@alilc/build-plugin-alt",`
`3`		`- "version": "1.3.0-beta.0",`
	`3`	`+ "version": "1.3.0",`
`4`	`4`	`"description": "build-scripts plugin template for developers",`
`5`	`5`	`"main": "lib/index.js",`
`6`	`6`	`"files": [`