Convert exception assertions to AssertJ in SeriestTest (exercism#2172)

kerolloz · web-flow · commit eb6da0bd6dce · 2022-10-11T00:30:15.000+01:00
diff --git a/exercises/practice/series/src/test/java/SeriesTest.java b/exercises/practice/series/src/test/java/SeriesTest.java
@@ -1,6 +1,5 @@
-import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertThrows;
+import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 
 import java.util.Arrays;
 import java.util.Collections;
@@ -83,55 +82,39 @@ public void slicesOfLongSeries() {
     public void sliceLengthIsToolarge() {
         Series series = new Series("12345");
 
-        IllegalArgumentException expected =
-            assertThrows(
-                IllegalArgumentException.class,
-                () -> series.slices(6));
-
-        assertThat(expected)
-            .hasMessage("Slice size is too big.");
+        assertThatExceptionOfType(IllegalArgumentException.class)
+                .isThrownBy(() -> series.slices(6))
+                .withMessage("Slice size is too big.");
     }
 
     @Ignore("Remove to run test")
     @Test
     public void sliceLengthZero() {
         Series series = new Series("12345");
 
-        IllegalArgumentException expected =
-            assertThrows(
-                IllegalArgumentException.class,
-                () -> series.slices(0));
-
-        assertThat(expected)
-            .hasMessage("Slice size is too small.");
+        assertThatExceptionOfType(IllegalArgumentException.class)
+                .isThrownBy(() -> series.slices(0))
+                .withMessage("Slice size is too small.");
     }
 
     @Ignore("Remove to run test")
     @Test
     public void sliceLengthNegative() {
         Series series = new Series("123");
 
-        IllegalArgumentException expected =
-            assertThrows(
-                IllegalArgumentException.class,
-                () -> series.slices(-1));
-
-        assertThat(expected)
-            .hasMessage("Slice size is too small.");
+        assertThatExceptionOfType(IllegalArgumentException.class)
+                .isThrownBy(() -> series.slices(-1))
+                .withMessage("Slice size is too small.");
     }
 
     @Ignore("Remove to run test")
     @Test
     public void emptySeries() {
         Series series = new Series("");
 
-        IllegalArgumentException expected =
-            assertThrows(
-                IllegalArgumentException.class,
-                () -> series.slices(1));
-
-        assertThat(expected)
-            .hasMessage("Slice size is too big.");
+        assertThatExceptionOfType(IllegalArgumentException.class)
+                .isThrownBy(() -> series.slices(1))
+                .withMessage("Slice size is too big.");
     }
 
 }
