Wizards and warriors: more generic param names for #damagePoints (exercism#2308)

andeemarks · sanderploegsma · web-flow · commit a952106e7bf9 · 2023-09-18T10:20:30.000+02:00
Within the context of the exercise, using explicit names for the Fighter params to #damagePoints is correct, but it seems overly specific given the topic being introduced is inheritance and only knowing the argument is of type Fighter is sufficient.

Co-authored-by: Sander Ploegsma &lt;sanderploegsma@gmail.com&gt;
diff --git a/exercises/concept/wizards-and-warriors/src/main/java/Fighter.java b/exercises/concept/wizards-and-warriors/src/main/java/Fighter.java
@@ -16,7 +16,7 @@ public String toString() {
     }
 
     @Override
-    int damagePoints(Fighter wizard) {
+    int damagePoints(Fighter fighter) {
         throw new UnsupportedOperationException("Please implement Warrior.damagePoints() method");
     }
 }
@@ -29,7 +29,7 @@ boolean isVulnerable() {
     }
 
     @Override
-    int damagePoints(Fighter warrior) {
+    int damagePoints(Fighter fighter) {
         throw new UnsupportedOperationException("Please implement Wizard.damagePoints() method");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public String toString() {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`@Override`
`19`		`- int damagePoints(Fighter wizard) {`
	`19`	`+ int damagePoints(Fighter fighter) {`
`20`	`20`	`throw new UnsupportedOperationException("Please implement Warrior.damagePoints() method");`
`21`	`21`	`}`
`22`	`22`	`}`
`@@ -29,7 +29,7 @@ boolean isVulnerable() {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`@Override`
`32`		`- int damagePoints(Fighter warrior) {`
	`32`	`+ int damagePoints(Fighter fighter) {`
`33`	`33`	`throw new UnsupportedOperationException("Please implement Wizard.damagePoints() method");`
`34`	`34`	`}`
`35`	`35`