Fix broken Java CI with Gradle workflow (exercism#1988)

jmrunkle · web-flow · commit 9df5e63c66d6 · 2021-09-05T19:26:28.000+01:00
* Fix broken Java CI with Gradle workflow Fixes exercism#1986 * Add stacktrace to improve error messaging We probably have to track down some pre-existing issues now to re-enable this. * Fix pre-existing issues in the exercises
diff --git a/.github/workflows/gradle.yml b/.github/workflows/gradle.yml
@@ -3,24 +3,9 @@
 
 name: Java CI with Gradle
 
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ master ]
+on: [push, pull_request, workflow_dispatch]
 
 jobs:
-  lint:
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: actions/checkout@v2
-    - name: Fetch configlet
-      run: bin/fetch-configlet
-    - name: Lint
-      run: bin/configlet lint .
-
   build:
 
     runs-on: ubuntu-latest
@@ -35,7 +20,7 @@ jobs:
     - name: Grant execute permission for gradlew
       run: chmod +x gradlew
     - name: Compile and checkstyle with Gradle
-      run: cd exercises && ../gradlew check compileStarterSourceJava --parallel --continue
+      run: cd exercises && ../gradlew check compileStarterSourceJava --parallel --continue --stacktrace
 
   test:
 
diff --git a/exercises/concept/need-for-speed/src/main/java/NeedForSpeed.java b/exercises/concept/need-for-speed/src/main/java/NeedForSpeed.java
@@ -1,20 +1,20 @@
 class NeedForSpeed {
-    // TODO: define the constructor for the 'RemoteControlCar' class
+    // TODO: define the constructor for the 'NeedForSpeed' class
 
     public boolean batteryDrained() {
-        throw new UnsupportedOperationException("Please implement the RemoteControlCar.batteryDrained() method");
+        throw new UnsupportedOperationException("Please implement the NeedForSpeed.batteryDrained() method");
     }
 
     public int distanceDriven() {
-        throw new UnsupportedOperationException("Please implement the RemoteControlCar.distanceDriven() method");
+        throw new UnsupportedOperationException("Please implement the NeedForSpeed.distanceDriven() method");
     }
 
     public void drive() {
-        throw new UnsupportedOperationException("Please implement the RemoteControlCar.drive() method");
+        throw new UnsupportedOperationException("Please implement the NeedForSpeed.drive() method");
     }
 
-    public static RemoteControlCar nitro() {
-        throw new UnsupportedOperationException("Please implement the (static) RemoteControlCar.ntiro() method");
+    public static NeedForSpeed nitro() {
+        throw new UnsupportedOperationException("Please implement the (static) NeedForSpeed.nitro() method");
     }
 }
 
diff --git a/exercises/concept/wizards-and-warriors/src/main/java/Fighter.java b/exercises/concept/wizards-and-warriors/src/main/java/Fighter.java
@@ -8,7 +8,7 @@ boolean isVulnerable() {
 
 }
 
-class Warrior extends WizardsAndWarriors {
+class Warrior extends Fighter {
 
     @Override
     public String toString() {
@@ -21,7 +21,7 @@ int damagePoints(Fighter wizard) {
     }
 }
 
-class Wizard extends WizardsAndWarriors {
+class Wizard extends Fighter {
 
     @Override
     boolean isVulnerable() {
diff --git a/exercises/practice/markdown/src/main/java/Markdown.java b/exercises/practice/markdown/src/main/java/Markdown.java
@@ -1,3 +1,4 @@
+class Markdown {
 
     String parse(String markdown) {
         String[] lines = markdown.split("\n");
@@ -76,4 +77,4 @@ private String parseSomeSymbols(String markdown) {
         update = "<em>$1</em>";
         return workingOn.replaceAll(lookingFor, update);
     }
-} 
+}

Original file line number	Diff line number	Diff line change
`@@ -1,20 +1,20 @@`
`1`	`1`	`class NeedForSpeed {`
`2`		`- // TODO: define the constructor for the 'RemoteControlCar' class`
	`2`	`+ // TODO: define the constructor for the 'NeedForSpeed' class`
`3`	`3`
`4`	`4`	`public boolean batteryDrained() {`
`5`		`- throw new UnsupportedOperationException("Please implement the RemoteControlCar.batteryDrained() method");`
	`5`	`+ throw new UnsupportedOperationException("Please implement the NeedForSpeed.batteryDrained() method");`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`public int distanceDriven() {`
`9`		`- throw new UnsupportedOperationException("Please implement the RemoteControlCar.distanceDriven() method");`
	`9`	`+ throw new UnsupportedOperationException("Please implement the NeedForSpeed.distanceDriven() method");`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`public void drive() {`
`13`		`- throw new UnsupportedOperationException("Please implement the RemoteControlCar.drive() method");`
	`13`	`+ throw new UnsupportedOperationException("Please implement the NeedForSpeed.drive() method");`
`14`	`14`	`}`
`15`	`15`
`16`		`- public static RemoteControlCar nitro() {`
`17`		`- throw new UnsupportedOperationException("Please implement the (static) RemoteControlCar.ntiro() method");`
	`16`	`+ public static NeedForSpeed nitro() {`
	`17`	`+ throw new UnsupportedOperationException("Please implement the (static) NeedForSpeed.nitro() method");`
`18`	`18`	`}`
`19`	`19`	`}`
`20`	`20`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ boolean isVulnerable() {`
`8`	`8`
`9`	`9`	`}`
`10`	`10`
`11`		`-class Warrior extends WizardsAndWarriors {`
	`11`	`+class Warrior extends Fighter {`
`12`	`12`
`13`	`13`	`@Override`
`14`	`14`	`public String toString() {`
`@@ -21,7 +21,7 @@ int damagePoints(Fighter wizard) {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`24`		`-class Wizard extends WizardsAndWarriors {`
	`24`	`+class Wizard extends Fighter {`
`25`	`25`
`26`	`26`	`@Override`
`27`	`27`	`boolean isVulnerable() {`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+class Markdown {`
`1`	`2`
`2`	`3`	`String parse(String markdown) {`
`3`	`4`	`String[] lines = markdown.split("\n");`
`@@ -76,4 +77,4 @@ private String parseSomeSymbols(String markdown) {`
`76`	`77`	`update = "<em>$1</em>";`
`77`	`78`	`return workingOn.replaceAll(lookingFor, update);`
`78`	`79`	`}`
`79`		`-}`
	`80`	`+}`