Change TestTrack.getRankedCars stub to take a list of cars, consistent with the unit tests (exercism#2337)

IsaacG · web-flow · commit 1cae70234804 · 2023-08-23T02:19:07.000+01:00
* Change TestTrack.getRankedCars stub to take a list of cars, consistent with the unit tests

* Update additional getRankedCars functions
diff --git a/exercises/concept/remote-control-competition/.docs/instructions.md b/exercises/concept/remote-control-competition/.docs/instructions.md
@@ -59,7 +59,7 @@ prc2.setNumberOfVictories(2);
 List<ProductionRemoteControlCar> unsortedCars = new ArrayList<>();
 unsortedCars.add(prc1);
 unsortedCars.add(prc2);
-List<ProductionRemoteControlCar> rankings = TestTrack.getRankedCars(prc1, prc2);
+List<ProductionRemoteControlCar> rankings = TestTrack.getRankedCars(unsortedCars);
 // => rankings.get(0) == prc2
 // => rankings.get(1) == prc1
 ```
diff --git a/exercises/concept/remote-control-competition/.meta/src/reference/java/TestTrack.java b/exercises/concept/remote-control-competition/.meta/src/reference/java/TestTrack.java
@@ -8,13 +8,9 @@ public static void race(RemoteControlCar car) {
         car.drive();
     }
 
-    public static List<ProductionRemoteControlCar> getRankedCars(ProductionRemoteControlCar prc1,
-                                                                 ProductionRemoteControlCar prc2) {
-        List<ProductionRemoteControlCar> rankings = new ArrayList<>();
-        rankings.add(prc1);
-        rankings.add(prc1);
-        Collections.sort(rankings);
-
-        return rankings;
+    public static List<ProductionRemoteControlCar> getRankedCars(List<ProductionRemoteControlCar> cars) {
+        List<ProductionRemoteControlCar> sorted = new ArrayList<>(cars);
+        Collections.sort(sorted);
+        return sorted;
     }
 }
diff --git a/exercises/concept/remote-control-competition/src/main/java/TestTrack.java b/exercises/concept/remote-control-competition/src/main/java/TestTrack.java
@@ -6,8 +6,7 @@ public static void race(RemoteControlCar car) {
         throw new UnsupportedOperationException("Please implement the (static) TestTrack.race() method");
     }
 
-    public static List<ProductionRemoteControlCar> getRankedCars(ProductionRemoteControlCar prc1,
-                                                                 ProductionRemoteControlCar prc2) {
+    public static List<ProductionRemoteControlCar> getRankedCars(List<ProductionRemoteControlCar> cars) {
         throw new UnsupportedOperationException("Please implement the (static) TestTrack.getRankedCars() method");
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,13 +8,9 @@ public static void race(RemoteControlCar car) {`
`8`	`8`	`car.drive();`
`9`	`9`	`}`
`10`	`10`
`11`		`- public static List<ProductionRemoteControlCar> getRankedCars(ProductionRemoteControlCar prc1,`
`12`		`- ProductionRemoteControlCar prc2) {`
`13`		`- List<ProductionRemoteControlCar> rankings = new ArrayList<>();`
`14`		`- rankings.add(prc1);`
`15`		`- rankings.add(prc1);`
`16`		`- Collections.sort(rankings);`
`17`		`-`
`18`		`- return rankings;`
	`11`	`+ public static List<ProductionRemoteControlCar> getRankedCars(List<ProductionRemoteControlCar> cars) {`
	`12`	`+ List<ProductionRemoteControlCar> sorted = new ArrayList<>(cars);`
	`13`	`+ Collections.sort(sorted);`
	`14`	`+ return sorted;`
`19`	`15`	`}`
`20`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,7 @@ public static void race(RemoteControlCar car) {`
`6`	`6`	`throw new UnsupportedOperationException("Please implement the (static) TestTrack.race() method");`
`7`	`7`	`}`
`8`	`8`
`9`		`- public static List<ProductionRemoteControlCar> getRankedCars(ProductionRemoteControlCar prc1,`
`10`		`- ProductionRemoteControlCar prc2) {`
	`9`	`+ public static List<ProductionRemoteControlCar> getRankedCars(List<ProductionRemoteControlCar> cars) {`
`11`	`10`	`throw new UnsupportedOperationException("Please implement the (static) TestTrack.getRankedCars() method");`
`12`	`11`	`}`
`13`	`12`	`}`