hacky way to ignore LineSlider in PlotArea.auto_scale()

kushalkolar · kushalkolar · commit 97a5680fb6d7 · 2022-12-29T16:17:48.000-05:00
diff --git a/fastplotlib/graphics/line_slider.py b/fastplotlib/graphics/line_slider.py
@@ -6,7 +6,7 @@
 from pygfx import TransformGizmo, Color
 from ipywidgets import IntSlider
 
-from ..graphics._base import Graphic
+from ._base import Graphic
 
 
 class LineSlider(Graphic):
diff --git a/fastplotlib/layouts/_base.py b/fastplotlib/layouts/_base.py
@@ -4,6 +4,7 @@
 from wgpu.gui.auto import WgpuCanvas
 from warnings import warn
 from ..graphics._base import Graphic
+from ..graphics.line_slider import LineSlider
 from typing import *
 
 
@@ -49,6 +50,9 @@ def __init__(
 
         self._graphics: List[Graphic] = list()
 
+        # hacky workaround for now to exclude from bbox calculations
+        self._sliders: List[LineSlider] = list()
+
         self.name = name
 
         # need to think about how to deal with children better
@@ -124,6 +128,11 @@ def add_graphic(self, graphic: Graphic, center: bool = True):
             Center the camera on the newly added Graphic
 
         """
+        if not isinstance(graphic, Graphic):
+            raise TypeError(
+                f"Can only add Graphic types to a PlotArea, you have passed a: {type(graphic)}"
+            )
+
         if graphic.name is not None:  # skip for those that have no name
             graphic_names = list()
 
@@ -133,12 +142,19 @@ def add_graphic(self, graphic: Graphic, center: bool = True):
             if graphic.name in graphic_names:
                 raise ValueError(f"graphics must have unique names, current graphic names are:\n {graphic_names}")
 
-        self._graphics.append(graphic)
+        if isinstance(graphic, LineSlider):
+            self._sliders.append(graphic)
+        else:
+            self._graphics.append(graphic)
+
         self.scene.add(graphic.world_object)
 
         if center:
             self.center_graphic(graphic)
 
+        # if hasattr(graphic, "_add_plot_area_hook"):
+        #     graphic._add_plot_area_hook(self.viewport, self.camera)
+
     def _refresh_camera(self):
         self.controller.update_camera(self.camera)
         if sum(self.renderer.logical_size) > 0:
@@ -214,8 +230,15 @@ def auto_scale(self, maintain_aspect: bool = False, zoom: float = 0.8):
             maintain_aspect = False  # assume False
         self.camera.maintain_aspect = maintain_aspect
 
+        # hacky workaround for now until I figure out how to put it in its own scene
+        for slider in self._sliders:
+            self.scene.remove(slider.world_object)
+
         width, height, depth = np.ptp(self.scene.get_world_bounding_box(), axis=0)
 
+        for slider in self._sliders:
+            self.scene.add(slider.world_object)
+
         self.camera.width = width
         self.camera.height = height
 
