fix limits when rect selector is added from image (#641)

kushalkolar · web-flow · commit 8409523b9022 · 2024-10-08T10:56:28.000-04:00
* fix limits when rect selector is added from image

* fix docstring
diff --git a/fastplotlib/graphics/image.py b/fastplotlib/graphics/image.py
@@ -419,7 +419,8 @@ def add_rectangle_selector(
             selection = (0, int(diagonal / 4), 0, int(diagonal / 4))
 
         # min/max limits are image shape
-        limits = (0, self._data.value.shape[0], 0, self._data.value.shape[1])
+        # rows are ys, columns are xs
+        limits = (0, self._data.value.shape[1], 0, self._data.value.shape[0])
 
         selector = RectangleSelector(
             selection=selection,
diff --git a/fastplotlib/graphics/selectors/_rectangle.py b/fastplotlib/graphics/selectors/_rectangle.py
@@ -430,7 +430,7 @@ def get_selected_indices(
         -------
         Union[np.ndarray, List[np.ndarray]]
             data indicies of the selection
-            | tuple of [row_indices, y_indices_array] if the graphic is an image
+            | tuple of [row_indices, col_indices] if the graphic is an image
             | list of indices along the x-dimension for each line if graphic is a line collection
             | array of indices along the x-dimension if graphic is a line
         """
