fix comment, fix doc example readme file (#769)

kushalkolar · web-flow · commit 61d7962cfc76 · 2025-03-17T14:07:52.000-04:00
* fix comment, fix doc example readme file

* update get_cmap_texture to return pygfx.Texture since cmap lib changed
diff --git a/examples/window_layouts/README.rst b/examples/window_layouts/README.rst
@@ -1,2 +1,2 @@
-WindowLayout Examples
-=====================
+Window Layout Examples
+======================
diff --git a/fastplotlib/layouts/_plot_area.py b/fastplotlib/layouts/_plot_area.py
@@ -87,12 +87,10 @@ def __init__(
         self._animate_funcs_pre: list[callable] = list()
         self._animate_funcs_post: list[callable] = list()
 
-        # list of hex id strings for all graphics managed by this PlotArea
-        # the real Graphic instances are managed by REFERENCES
+        # list of all graphics managed by this PlotArea
         self._graphics: list[Graphic] = list()
 
         # selectors are in their own list so they can be excluded from scene bbox calculations
-        # managed similar to GRAPHICS for garbage collection etc.
         self._selectors: list[BaseSelector] = list()
 
         # legends, managed just like other graphics as explained above
diff --git a/fastplotlib/utils/functions.py b/fastplotlib/utils/functions.py
@@ -205,7 +205,7 @@ def make_colors(n_colors: int, cmap: str, alpha: float = 1.0) -> np.ndarray:
 
 
 def get_cmap_texture(name: str, alpha: float = 1.0) -> Texture:
-    return cmap_lib.Colormap(name).to_pygfx()
+    return Texture(get_cmap(name, alpha), dim=1)
 
 
 def make_colors_dict(labels: Sequence, cmap: str, **kwargs) -> OrderedDict:
diff --git a/tests/test_image_graphic.py b/tests/test_image_graphic.py
@@ -2,6 +2,8 @@
 from numpy import testing as npt
 import imageio.v3 as iio
 
+import pygfx
+
 import fastplotlib as fpl
 from fastplotlib.graphics._features import FeatureEvent
 from fastplotlib.utils import make_colors
@@ -86,6 +88,10 @@ def test_gray():
     # the entire image should be in the single Texture buffer
     npt.assert_almost_equal(ig.data.buffer[0, 0].data, GRAY_IMAGE)
 
+    assert isinstance(ig._material, pygfx.ImageBasicMaterial)
+    assert isinstance(ig._material.map, pygfx.TextureMap)
+    assert isinstance(ig._material.map.texture, pygfx.Texture)
+
     ig.cmap = "viridis"
     assert ig.cmap == "viridis"
     check_event(graphic=ig, feature="cmap", value="viridis")
