use LineInfiniteSegmentMaterial for LinearSelector (#813)

kushalkolar · web-flow · commit 29d4a87f518c · 2025-05-09T21:56:39.000-04:00
* use LineInfiniteSegmentMaterial

* remove comment

* linear selector wasn't in screenshot tests

* linear selector ground truths
diff --git a/examples/screenshots/linear_selector.png b/examples/screenshots/linear_selector.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:09f60f24e702dd6b17ba525604c1a04f23682eb08c8c2100d45a34b2626bebc6
-size 153115
+oid sha256:62ded18658bc5cb41129d27eb21f47f029cf7c75bb6388b5d72af6fe9c5cada9
+size 130919
diff --git a/examples/screenshots/no-imgui-linear_selector.png b/examples/screenshots/no-imgui-linear_selector.png
@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:1f1a323dec6d50d1c701632aadbd17d87ee3b3b42171046ca9b1284f93576a3b
+size 131922
diff --git a/examples/selection_tools/linear_selector.py b/examples/selection_tools/linear_selector.py
@@ -5,7 +5,7 @@
 Example showing how to use a `LinearSelector` with lines and line collections.
 """
 
-# test_example = false
+# test_example = true
 # sphinx_gallery_pygfx_docs = 'screenshot'
 
 import fastplotlib as fpl
diff --git a/fastplotlib/graphics/image.py b/fastplotlib/graphics/image.py
@@ -312,8 +312,6 @@ def add_linear_selector(
         selector = LinearSelector(
             selection=selection,
             limits=limits,
-            size=size,
-            center=center,
             axis=axis,
             parent=self,
             **kwargs,
diff --git a/fastplotlib/graphics/line.py b/fastplotlib/graphics/line.py
@@ -166,8 +166,6 @@ def add_linear_selector(
         selector = LinearSelector(
             selection=selection,
             limits=limits,
-            size=size,
-            center=center,
             axis=axis,
             parent=self,
             **kwargs,
diff --git a/fastplotlib/graphics/line_collection.py b/fastplotlib/graphics/line_collection.py
@@ -374,8 +374,6 @@ def add_linear_selector(
         selector = LinearSelector(
             selection=selection,
             limits=limits,
-            size=size,
-            center=center,
             axis=axis,
             parent=self,
             **kwargs,
diff --git a/fastplotlib/graphics/selectors/_linear.py b/fastplotlib/graphics/selectors/_linear.py
@@ -75,8 +75,6 @@ def __init__(
         self,
         selection: float,
         limits: Sequence[float],
-        size: float,
-        center: float,
         axis: str = "x",
         parent: Graphic = None,
         edge_color: str | Sequence[float] | np.ndarray = "w",
@@ -95,12 +93,6 @@ def __init__(
         limits: (int, int)
             (min, max) limits along the x or y-axis for the selector, in data space
 
-        size: float
-            size of the selector, usually the range of the data
-
-        center: float
-            center offset of the selector on the orthogonal axis, usually the data mean
-
         axis: str, default "x"
             "x" | "y", the axis along which the selector can move
 
@@ -131,29 +123,22 @@ def __init__(
 
         self._limits = np.asarray(limits)
 
-        end_points = [-size / 2, size / 2]
-
         if axis == "x":
-            xs = np.array([selection, selection])
-            ys = np.array(end_points)
-            zs = np.zeros(2)
+            xs = np.array([selection, selection], dtype=np.float32)
+            ys = np.array([0, 1], dtype=np.float32)
+            zs = np.zeros(2, dtype=np.float32)
 
-            line_data = np.column_stack([xs, ys, zs])
         elif axis == "y":
-            xs = np.array(end_points)
-            ys = np.array([selection, selection])
-            zs = np.zeros(2)
+            xs = np.array([0, 1], dtype=np.float32)
+            ys = np.array([selection, selection], dtype=np.float32)
+            zs = np.zeros(2, dtype=np.float32)
 
-            line_data = np.column_stack([xs, ys, zs])
         else:
-            raise ValueError("`axis` must be one of 'x' or 'y'")
+            raise ValueError("`axis` must be one of 'x' | 'y'")
 
-        line_data = line_data.astype(np.float32)
+        line_data = np.column_stack([xs, ys, zs])
 
-        if thickness < 1.1:
-            material = pygfx.LineThinMaterial
-        else:
-            material = pygfx.LineMaterial
+        material = pygfx.LineInfiniteSegmentMaterial
 
         self.colors_outer = pygfx.Color([0.3, 0.3, 0.3, 1.0])
 
@@ -178,9 +163,9 @@ def __init__(
         world_object.add(line_inner)
 
         if axis == "x":
-            offset = (parent.offset[0], center + parent.offset[1], 0)
+            offset = (parent.offset[0], 0, 0)
         elif axis == "y":
-            offset = (center + parent.offset[0], parent.offset[1], 0)
+            offset = (0, parent.offset[1], 0)
 
         # init base selector
         BaseSelector.__init__(
