fixed a couple things with win32 build

joeferner · joeferner · commit 4cba4290beea · 2012-01-25T00:23:26.000-05:00
diff --git a/README.md b/README.md
@@ -12,11 +12,11 @@ $ npm install java
 ## Installation Windows
 
 * [Install node.js from source](https://github.com/joyent/node/wiki/Installation)
-* The directory where jvm.dll exists must be in the PATH.
+* The directory where jvm.dll exists must be in the PATH. (e.g. C:\Program Files (x86)\Java\jdk1.6.0_18\jre\bin\client)
 
 ```bash
-$ set NODE_ROOT=C:\Program Files (x86)\nodejs
-$ vcbuild.bat
+$ set NODE_PATH=C:\dev\node-v0.6.8-0
+$ npm install java
 ```
 
 ## Installation Mac
diff --git a/build.js b/build.js
@@ -85,6 +85,12 @@ function Builder() {
   this.linker = "g++";
   this.objectFiles = [];
 
+	if(process.platform == 'win32') {
+		if(!process.env["VCINSTALLDIR"] && !process.env["VS100COMNTOOLS"]) {
+			this.fail("You appear to not be running in a Visual Studio prompt.");
+		}
+	}
+
 	if(process.platform == 'win32') {
 		this.cppCompiler = "cl.exe";
 		this.linker = "link.exe";
@@ -426,7 +432,10 @@ Builder.prototype.fail = function(message) {
 }
 
 Builder.prototype.trimQuotes = function(str) {
-	return str.replace(/^"/, '').replace(/"$/, '');
+	if(str) {
+		str = str.replace(/^"/, '').replace(/"$/, '');
+	}
+	return str;
 }
 
 build(new Builder());
