Comments: in WP_Comment_Query::fill_descendants(), compute count() in the first for expression so that it does not run on each iteration.

staylor · staylor · commit f6fced867b29 · 2016-08-21T06:24:18.000Z
Props vishalkakadiya, deremohan. Fixes #37416. git-svn-id: https://develop.svn.wordpress.org/trunk@38297 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/class-wp-comment-query.php b/src/wp-includes/class-wp-comment-query.php
@@ -1012,7 +1012,7 @@ protected function fill_descendants( $comments ) {
 
 		// Prime comment caches for non-top-level comments.
 		$descendant_ids = array();
-		for ( $i = 1; $i < count( $levels ); $i++ ) {
+		for ( $i = 1, $c = count( $levels ); $i <= $c; $i++ ) {
 			$descendant_ids = array_merge( $descendant_ids, $levels[ $i ] );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1012,7 +1012,7 @@ protected function fill_descendants( $comments ) {`
`1012`	`1012`
`1013`	`1013`	`// Prime comment caches for non-top-level comments.`
`1014`	`1014`	`$descendant_ids = array();`
`1015`		`- for ( $i = 1; $i < count( $levels ); $i++ ) {`
	`1015`	`+ for ( $i = 1, $c = count( $levels ); $i <= $c; $i++ ) {`
`1016`	`1016`	`$descendant_ids = array_merge( $descendant_ids, $levels[ $i ] );`
`1017`	`1017`	`}`
`1018`	`1018`