Remove unused variables in tao/toaster/ServerInstance.cpp

r-barnes · facebook-github-bot · commit c0135e4e6e82 · 2024-04-11T15:23:49.000-07:00
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept &amp; Ship" button :-)

Reviewed By: palmje

Differential Revision: D56022430

fbshipit-source-id: e75a3470b98b6dc52c904eb84c201a2c1198000a
diff --git a/fbclock/cpp_test/test.cpp b/fbclock/cpp_test/test.cpp
@@ -194,7 +194,6 @@ TEST(fbclock_test, test_fbclock_calculate_time) {
 }
 
 TEST(fbclock_test, test_fbclock_apply_utc_offset) {
-  int err;
   fbclock_truetime truetime;
   truetime.earliest_ns = 1647269091803102338;
   truetime.latest_ns = 1647269091803103576;

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,6 @@ TEST(fbclock_test, test_fbclock_calculate_time) {`
`194`	`194`	`}`
`195`	`195`
`196`	`196`	`TEST(fbclock_test, test_fbclock_apply_utc_offset) {`
`197`		`- int err;`
`198`	`197`	`fbclock_truetime truetime;`
`199`	`198`	`truetime.earliest_ns = 1647269091803102338;`
`200`	`199`	`truetime.latest_ns = 1647269091803103576;`