Add keyboardAppearance prop to TextInput component.#4012
Closed
christopherdro wants to merge 1 commit into
Closed
Conversation
Contributor
|
By analyzing the blame information on this pull request, we identified @nicklockwood, @sahrens and @brentvatne to be potential reviewers. |
Contributor
|
Looks good and is consistent with the other APIs. If you have time, could you add an example to the UIExplorer too? |
Contributor
|
As @ide says, an example would be great. Other than that, looks good to me. |
christopherdro
force-pushed
the
keyboardAppearance
branch
from
November 9, 2015 21:20
4b79c7e to
38bd24b
Compare
christopherdro
force-pushed
the
keyboardAppearance
branch
from
November 9, 2015 21:21
38bd24b to
0998d79
Compare
Contributor
Author
|
@ide @nicklockwood Done. |
Contributor
|
@christopherdro updated the pull request. |
Contributor
|
Thanks! |
Contributor
|
@facebook-github-bot import |
Contributor
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/778005025655512/int_phab to review. |
Contributor
|
Note: I removed the "alert" style, as it's deprecated. |
ide
pushed a commit
to expo/react-native
that referenced
this pull request
Nov 13, 2015
Summary: Resolves react#3649. Closes react#4012 Reviewed By: javache Differential Revision: D2636538 Pulled By: nicklockwood fb-gh-sync-id: 022e79d8f8fa684cad43af1a51f728d60ac652a8
sunnylqm
pushed a commit
to sunnylqm/react-native
that referenced
this pull request
Dec 2, 2015
Summary: Resolves react#3649. Closes react#4012 Reviewed By: javache Differential Revision: D2636538 Pulled By: nicklockwood fb-gh-sync-id: 022e79d8f8fa684cad43af1a51f728d60ac652a8
Crash--
pushed a commit
to Crash--/react-native
that referenced
this pull request
Dec 24, 2015
Summary: Resolves react#3649. Closes react#4012 Reviewed By: javache Differential Revision: D2636538 Pulled By: nicklockwood fb-gh-sync-id: 022e79d8f8fa684cad43af1a51f728d60ac652a8
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3649.