Skip to content

Make onUncaughtError and onCaughtError Configurable #28641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebmarkbage merged 7 commits into from
Mar 27, 2024
+1,115 −275
Merged

Make onUncaughtError and onCaughtError Configurable #28641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f207d70
Split logCapturedError into logUncaughtError and logCaughtError
sebmarkbage Mar 25, 2024
60a45da
Make onCaughtError and onUncaughtError configurable
sebmarkbage Mar 26, 2024
3bc6080
Unfork ReactFiberErrorDialog and implement it using the new config op…
sebmarkbage Mar 26, 2024
0ad2574
www mock
sebmarkbage Mar 27, 2024
65607a8
Update test
sebmarkbage Mar 27, 2024
d142b8c
Update errors
sebmarkbage Mar 27, 2024
14edf65
Gate tests
sebmarkbage Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unfork ReactFiberErrorDialog and implement it using the new config op… 
…tions
  • Loading branch information
@sebmarkbage
sebmarkbage committed Mar 27, 2024
commit 3bc60805e9fe8c418ab02116575ec014c1eb9cbe
5 changes: 2 additions & 3 deletions packages/react-dom/index.classic.fb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,8 @@ Object.assign((Internals: any), {

export {
createPortal,
createRoot,
hydrateRoot,
findDOMNode,
flushSync,
render,
unmountComponentAtNode,
unstable_batchedUpdates,
unstable_createEventHandle,
Expand All @@ -41,4 +38,6 @@ export {
version,
} from './src/client/ReactDOM';

export {createRoot, hydrateRoot, render} from './src/client/ReactDOMRootFB';

export {Internals as __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED};
4 changes: 2 additions & 2 deletions packages/react-dom/index.modern.fb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
export {default as __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED} from './src/ReactDOMSharedInternals';
export {
createPortal,
createRoot,
hydrateRoot,
flushSync,
unstable_batchedUpdates,
unstable_createEventHandle,
Expand All @@ -26,3 +24,5 @@ export {
preinitModule,
version,
} from './src/client/ReactDOM';

export {createRoot, hydrateRoot} from './src/client/ReactDOMRootFB';
Loading