Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: expr-lang/expr
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: expr-lang/expr
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: diegommm-make-checker-reusable
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 17 files changed
  • 1 contributor

Commits on Aug 28, 2025

  1. export the checker and ensure no methods or fields are exported

    @diegommm
    diegommm committed Aug 28, 2025
    Configuration menu
    Copy the full SHA
    359dd99 View commit details
    Browse the repository at this point in the history

  2. make Checker reusable

    @diegommm
    diegommm committed Aug 28, 2025
    Configuration menu
    Copy the full SHA
    360157a View commit details
    Browse the repository at this point in the history

  3. add PatchAndCheck method to Checker, and reuse it in visitors

    @diegommm
    diegommm committed Aug 28, 2025
    Configuration menu
    Copy the full SHA
    d234ae3 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2025

  1. avoid unnecessary map and consolidate structs

    @diegommm
    diegommm committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    edce1b0 View commit details
    Browse the repository at this point in the history

  2. make all Nature methods use pointer-receiver

    @diegommm
    diegommm committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    80afb76 View commit details
    Browse the repository at this point in the history

  3. added cache for type and nature information

    @diegommm
    diegommm committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    1c36c13 View commit details
    Browse the repository at this point in the history

  4. optimize type and nature checks

    @diegommm
    diegommm committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    e9b245b View commit details
    Browse the repository at this point in the history

  5. more aggressively cache some partial results and add cheap checks

    @diegommm
    diegommm committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    879544e View commit details
    Browse the repository at this point in the history

  6. cache reused values

    @diegommm
    diegommm committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    8f6e266 View commit details
    Browse the repository at this point in the history

  7. reduce copying in Nature by breaking down optional fields

    @diegommm
    diegommm committed Aug 29, 2025
    Configuration menu
    Copy the full SHA
    1eb8ab5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2025

  1. enforce use of cache

    @diegommm
    diegommm committed Aug 30, 2025
    Configuration menu
    Copy the full SHA
    06a425b View commit details
    Browse the repository at this point in the history

  2. improve ergonomics of FromType and NatureOf

    @diegommm
    diegommm committed Aug 30, 2025
    Configuration menu
    Copy the full SHA
    d9ba735 View commit details
    Browse the repository at this point in the history

  3. improve struct method fetching

    @diegommm
    diegommm committed Aug 30, 2025
    Configuration menu
    Copy the full SHA
    aa33cf9 View commit details
    Browse the repository at this point in the history

  4. make cache private to Nature

    @diegommm
    diegommm committed Aug 30, 2025
    Configuration menu
    Copy the full SHA
    ab994ae View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2025

  1. first iteration improving struct reflect caching

    @diegommm
    diegommm committed Aug 31, 2025
    Configuration menu
    Copy the full SHA
    720d2b6 View commit details
    Browse the repository at this point in the history

  2. cleaned up struct fields data

    @diegommm
    diegommm committed Aug 31, 2025
    Configuration menu
    Copy the full SHA
    35e3c1e View commit details
    Browse the repository at this point in the history

  3. improve caching of functions data

    @diegommm
    diegommm committed Aug 31, 2025
    Configuration menu
    Copy the full SHA
    e68fbc7 View commit details
    Browse the repository at this point in the history

  4. simplify checker code

    @diegommm
    diegommm committed Aug 31, 2025
    Configuration menu
    Copy the full SHA
    3d7e30e View commit details
    Browse the repository at this point in the history

  5. simplify and remove dead code

    @diegommm
    diegommm committed Aug 31, 2025
    Configuration menu
    Copy the full SHA
    163df86 View commit details
    Browse the repository at this point in the history

  6. add checker benchmarks

    @diegommm
    diegommm committed Aug 31, 2025
    Configuration menu
    Copy the full SHA
    40d2c14 View commit details
    Browse the repository at this point in the history
Loading