Skip to content

Commit 0fb742a

Browse files
committed
Avoid unnecessary conversion to ConsistencyLevel in QueryTraceFetcher
1 parent d846fac commit 0fb742a

2 files changed

Lines changed: 3 additions & 14 deletions

File tree

core/src/main/java/com/datastax/oss/driver/internal/core/cql/QueryTraceFetcher.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package com.datastax.oss.driver.internal.core.cql;
1717

18-
import com.datastax.oss.driver.api.core.ConsistencyLevel;
1918
import com.datastax.oss.driver.api.core.CqlSession;
2019
import com.datastax.oss.driver.api.core.config.DefaultDriverOption;
2120
import com.datastax.oss.driver.api.core.config.DriverExecutionProfile;
@@ -56,18 +55,12 @@ class QueryTraceFetcher {
5655
this.tracingId = tracingId;
5756
this.session = session;
5857

59-
ConsistencyLevel regularConsistency =
60-
context
61-
.getConsistencyLevelRegistry()
62-
.fromName(config.getString(DefaultDriverOption.REQUEST_CONSISTENCY));
63-
ConsistencyLevel traceConsistency =
64-
context
65-
.getConsistencyLevelRegistry()
66-
.fromName(config.getString(DefaultDriverOption.REQUEST_TRACE_CONSISTENCY));
58+
String regularConsistency = config.getString(DefaultDriverOption.REQUEST_CONSISTENCY);
59+
String traceConsistency = config.getString(DefaultDriverOption.REQUEST_TRACE_CONSISTENCY);
6760
this.config =
6861
(traceConsistency.equals(regularConsistency))
6962
? config
70-
: config.withString(DefaultDriverOption.REQUEST_CONSISTENCY, traceConsistency.name());
63+
: config.withString(DefaultDriverOption.REQUEST_CONSISTENCY, traceConsistency);
7164

7265
this.maxAttempts = config.getInt(DefaultDriverOption.REQUEST_TRACE_ATTEMPTS);
7366
this.intervalNanos = config.getDuration(DefaultDriverOption.REQUEST_TRACE_INTERVAL).toNanos();

core/src/test/java/com/datastax/oss/driver/internal/core/cql/QueryTraceFetcherTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import com.datastax.oss.driver.api.core.cql.SimpleStatement;
3333
import com.datastax.oss.driver.api.core.cql.TraceEvent;
3434
import com.datastax.oss.driver.api.core.uuid.Uuids;
35-
import com.datastax.oss.driver.internal.core.DefaultConsistencyLevelRegistry;
3635
import com.datastax.oss.driver.internal.core.context.InternalDriverContext;
3736
import com.datastax.oss.driver.internal.core.context.NettyOptions;
3837
import com.datastax.oss.driver.internal.core.util.concurrent.CompletableFutures;
@@ -105,9 +104,6 @@ public void setup() {
105104
config.withString(
106105
DefaultDriverOption.REQUEST_CONSISTENCY, DefaultConsistencyLevel.ONE.name()))
107106
.thenReturn(traceConfig);
108-
109-
Mockito.when(context.getConsistencyLevelRegistry())
110-
.thenReturn(new DefaultConsistencyLevelRegistry());
111107
}
112108

113109
@Test

0 commit comments

Comments
 (0)