fix: sqlite log (sqlc-dev#2488)

mcdoker18 · web-flow · commit fdeb61873f74 · 2023-07-24T12:24:32.000-04:00
Fixes: sqlc-dev#2391
diff --git a/internal/codegen/golang/imports.go b/internal/codegen/golang/imports.go
@@ -188,7 +188,7 @@ func buildImports(settings *plugin.Settings, queries []Query, uses func(string)
 		}
 	}
 
-	for typeName, _ := range pqtypeTypes {
+	for typeName := range pqtypeTypes {
 		if uses(typeName) {
 			pkg[ImportSpec{Path: "github.com/sqlc-dev/pqtype"}] = struct{}{}
 			break
diff --git a/internal/codegen/golang/sqlite_type.go b/internal/codegen/golang/sqlite_type.go
@@ -5,6 +5,7 @@ import (
 	"strings"
 
 	"github.com/kyleconroy/sqlc/internal/codegen/sdk"
+	"github.com/kyleconroy/sqlc/internal/debug"
 	"github.com/kyleconroy/sqlc/internal/plugin"
 )
 
@@ -68,7 +69,10 @@ func sqliteType(req *plugin.CodeGenRequest, col *plugin.Column) string {
 		return "sql.NullFloat64"
 
 	default:
-		log.Printf("unknown SQLite type: %s\n", dt)
+		if debug.Active {
+			log.Printf("unknown SQLite type: %s\n", dt)
+		}
+
 		return "interface{}"
 
 	}

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ func buildImports(settings *plugin.Settings, queries []Query, uses func(string)`
`188`	`188`	`}`
`189`	`189`	`}`
`190`	`190`
`191`		`- for typeName, _ := range pqtypeTypes {`
	`191`	`+ for typeName := range pqtypeTypes {`
`192`	`192`	`if uses(typeName) {`
`193`	`193`	`pkg[ImportSpec{Path: "github.com/sqlc-dev/pqtype"}] = struct{}{}`
`194`	`194`	`break`