two-bucket: skip broken/unimplemented tests

SleeplessByte · SleeplessByte · commit b66e82db2679 · 2020-12-24T15:03:14.000+01:00
diff --git a/exercises/alphametics/alphametics.spec.js b/exercises/alphametics/alphametics.spec.js
@@ -91,7 +91,7 @@ describe('Solve the alphametics puzzle', () => {
     expect(solve(puzzle)).toEqual(expected);
   });
 
-  xtest('puzzle with ten letters and 199 addends', () => {
+  test.skip('puzzle with ten letters and 199 addends', () => {
     const puzzle =
       'THIS + A + FIRE + THEREFORE + FOR + ALL + HISTORIES + I + TELL + A + TALE + THAT + FALSIFIES + ITS + TITLE + TIS + A + LIE + THE + TALE + OF + THE + LAST + FIRE + HORSES + LATE + AFTER + THE + FIRST + FATHERS + FORESEE + THE + HORRORS + THE + LAST + FREE + TROLL + TERRIFIES + THE + HORSES + OF + FIRE + THE + TROLL + RESTS + AT + THE + HOLE + OF + LOSSES + IT + IS + THERE + THAT + SHE + STORES + ROLES + OF + LEATHERS + AFTER + SHE + SATISFIES + HER + HATE + OFF + THOSE + FEARS + A + TASTE + RISES + AS + SHE + HEARS + THE + LEAST + FAR + HORSE + THOSE + FAST + HORSES + THAT + FIRST + HEAR + THE + TROLL + FLEE + OFF + TO + THE + FOREST + THE + HORSES + THAT + ALERTS + RAISE + THE + STARES + OF + THE + OTHERS + AS + THE + TROLL + ASSAILS + AT + THE + TOTAL + SHIFT + HER + TEETH + TEAR + HOOF + OFF + TORSO + AS + THE + LAST + HORSE + FORFEITS + ITS + LIFE + THE + FIRST + FATHERS + HEAR + OF + THE + HORRORS + THEIR + FEARS + THAT + THE + FIRES + FOR + THEIR + FEASTS + ARREST + AS + THE + FIRST + FATHERS + RESETTLE + THE + LAST + OF + THE + FIRE + HORSES + THE + LAST + TROLL + HARASSES + THE + FOREST + HEART + FREE + AT + LAST + OF + THE + LAST + TROLL + ALL + OFFER + THEIR + FIRE + HEAT + TO + THE + ASSISTERS + FAR + OFF + THE + TROLL + FASTS + ITS + LIFE + SHORTER + AS + STARS + RISE + THE + HORSES + REST + SAFE + AFTER + ALL + SHARE + HOT + FISH + AS + THEIR + AFFILIATES + TAILOR + A + ROOFS + FOR + THEIR + SAFE == FORTRESSES';
     const expected = {
diff --git a/exercises/crypto-square/crypto-square.spec.js b/exercises/crypto-square/crypto-square.spec.js
@@ -31,7 +31,7 @@ describe('Crypto', () => {
     expect(crypto.ciphertext).toEqual('clu hlt io ');
   });
 
-  xtest.skip('54 character plaintext results in 7 chunks, the last two with trailing spaces', () => {
+  test.skip('54 character plaintext results in 7 chunks, the last two with trailing spaces', () => {
     const crypto = new Crypto(
       'If man was meant to stay on the ground, god would have given us roots.'
     );
diff --git a/exercises/palindrome-products/palindrome-products.spec.js b/exercises/palindrome-products/palindrome-products.spec.js
@@ -79,7 +79,7 @@ describe('Palindromes', () => {
     expect(sortFactors(smallest.factors)).toEqual(expected.factors);
   });
 
-  xtest('largest palindrome from four digit factors', () => {
+  test.skip('largest palindrome from four digit factors', () => {
     const palindromes = Palindromes.generate({
       maxFactor: 9999,
       minFactor: 1000,
diff --git a/exercises/two-bucket/two-bucket.spec.js b/exercises/two-bucket/two-bucket.spec.js
@@ -59,7 +59,7 @@ describe('TwoBucket', () => {
   });
 
   describe('Measure using bucket one of size 2 and bucket two of size 3', () => {
-    xtest('start with bucket one and end with bucket two', () => {
+    test.skip('start with bucket one and end with bucket two', () => {
       const twoBucket = new TwoBucket(2, 3, 3, 'one');
       expect(twoBucket.moves()).toEqual(2);
       expect(twoBucket.goalBucket).toEqual('two');
@@ -72,7 +72,7 @@ describe('TwoBucket', () => {
     const buckTwo = 15;
     const starterBuck = 'one';
 
-    xtest('Not possible to reach the goal', () => {
+    test.skip('Not possible to reach the goal', () => {
       const goal = 5;
       const twoBucket = new TwoBucket(buckOne, buckTwo, goal, starterBuck);
       expect(twoBucket.moves()).toThrow();
@@ -88,7 +88,7 @@ describe('TwoBucket', () => {
   });
 
   describe('Goal larger than both buckets', () => {
-    xtest('Is impossible', () => {
+    test.skip('Is impossible', () => {
       const twoBucket = new TwoBucket(5, 7, 8, 'one');
       expect(twoBucket.moves()).toThrow();
     });
diff --git a/package.json b/package.json
@@ -26,7 +26,8 @@
   "jest": {
     "modulePathIgnorePatterns": [
       "package.json"
-    ]
+    ],
+    "testSequencer": "./testSequencer.js"
   },
   "scripts": {
     "test": "jest --no-cache ./*",
diff --git a/scripts/pr b/scripts/pr
@@ -18,20 +18,20 @@ const {
   cleanUp,
   registerExitHandler,
   assignments,
-} = require("./helpers");
+} = require('./helpers');
 
-const shell = require("shelljs");
-const path = require("path");
+const shell = require('shelljs');
+const path = require('path');
 const files = process.argv.slice(2);
 
 if (files.length === 0) {
   shell.echo(
-    "[Failure] No files passed in. Pass in paths to exercise directories or its file."
+    '[Failure] No files passed in. Pass in paths to exercise directories or its file.'
   );
   shell.exit(-1);
 }
 
-shell.echo("[Files] The files passed in are as follows:");
+shell.echo('[Files] The files passed in are as follows:');
 files.forEach((file) => {
   shell.echo(`[Files] ${file}`);
 });
@@ -44,42 +44,42 @@ const _exercises = files
   .filter(Boolean)
   .filter((exercise, index, array) => array.indexOf(exercise) === index);
 
-const hasRootFile = files.some((file) => file === "package.json");
+const hasRootFile = files.some((file) => file === 'package.json');
 
 if (hasRootFile) {
   shell.echo(
-    "[Root PR] When package.json is changed, all exercises need to be checked"
+    '[Root PR] When package.json is changed, all exercises need to be checked'
   );
 } else if (_exercises.length > 8) {
   shell.echo(
-    "[Big PR] When more than 8 exercises are being checked, all of them are " +
-      "checked as this is likely a PR affecting everything."
+    '[Big PR] When more than 8 exercises are being checked, all of them are ' +
+      'checked as this is likely a PR affecting everything.'
   );
 }
 
 const exercises =
   hasRootFile || _exercises.length > 8 ? assignments : _exercises;
 
 if (exercises.length === 0) {
-  shell.echo("[Skip] None of the files are inside an exercise directory.");
+  shell.echo('[Skip] None of the files are inside an exercise directory.');
   shell.exit(0);
 }
 
 registerExitHandler();
 
-shell.env["PREPARE"] = false;
-shell.env["CLEANUP"] = false;
+shell.env['PREPARE'] = false;
+shell.env['CLEANUP'] = false;
 
 const infoStr = `Running tests for ${
   exercises.length === 1 ? exercises[0] : `${exercises.length} exercises\n`
 }`;
-const failureStr = "[Failure] Tests failed!";
+const failureStr = '[Failure] Tests failed!';
 
 // Prepare exercises
 exercises.forEach(prepare);
 
 // Run tests
-prepareAndRun("npx jest --bail tmp_exercises", infoStr, failureStr);
+prepareAndRun('npx jest --bail tmp_exercises --runInBand', infoStr, failureStr);
 
 shell.echo(
   exercises.length === 1
diff --git a/testSequencer.js b/testSequencer.js
@@ -0,0 +1,13 @@
+// testSequencer.js
+const Sequencer = require('@jest/test-sequencer').default;
+
+class CustomSequencer extends Sequencer {
+  sort(tests) {
+    // Test structure information
+    // https://github.com/facebook/jest/blob/6b8b1404a1d9254e7d5d90a8934087a9c9899dab/packages/jest-runner/src/types.ts#L17-L21
+    const copyTests = Array.from(tests);
+    return copyTests.sort((testA, testB) => (testA.path > testB.path ? 1 : -1));
+  }
+}
+
+module.exports = CustomSequencer;
