Skip to content

Adding state of tic tac toe practice exercise#2647

Merged
sanderploegsma merged 7 commits into
exercism:mainfrom
manumafe98:AddStateOfTicTacToePracticeExercise
Jan 16, 2024
Merged

Adding state of tic tac toe practice exercise#2647
sanderploegsma merged 7 commits into
exercism:mainfrom
manumafe98:AddStateOfTicTacToePracticeExercise

Conversation

@manumafe98
Copy link
Copy Markdown
Contributor

@manumafe98 manumafe98 commented Jan 15, 2024

pull request

Fixes #2360

The goal is to add the state of tic tac toe exercise to the java track

Reviewer Resources:

Track Policies

@manumafe98
Copy link
Copy Markdown
Contributor Author

I don't get why configlet fails here ngl, the only extra addition I made to the one in .meta is the editor part for the enum, and i got that idea for other exercises.

@sanderploegsma
Copy link
Copy Markdown
Contributor

I don't get why configlet fails here ngl, the only extra addition I made to the one in .meta is the editor part for the enum, and i got that idea for other exercises.

I believe it's complaining about the formatting of the file. IIRC it expects the keys in a particular order. Easiest way to fix is to run

bin/configlet fmt --update

@manumafe98
Copy link
Copy Markdown
Contributor Author

Thanks for the information Sander!

Copy link
Copy Markdown
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, well done!

Just a few things to fix before we can merge.

Comment thread exercises/practice/state-of-tic-tac-toe/.meta/src/reference/java/GameStates.java Outdated
Comment thread exercises/practice/state-of-tic-tac-toe/src/main/java/StateOfTicTacToe.java Outdated
@sanderploegsma sanderploegsma added the x:size/large Large amount of work label Jan 16, 2024
@manumafe98
Copy link
Copy Markdown
Contributor Author

The configlet start to fail again, that's weird

/e/repos/java (AddStateOfTicTacToePracticeExercise)
$ bin/configlet fmt --update
Found 20 Concept Exercises and 133 Practice Exercises in E:\repos\java\config.json
Looking for exercises that lack a formatted '.meta/config.json', '.approaches/config.json'
or '.articles/config.json' file...
Every exercise config is already formatted!

@sanderploegsma
Copy link
Copy Markdown
Contributor

The configlet start to fail again, that's weird

/e/repos/java (AddStateOfTicTacToePracticeExercise)
$ bin/configlet fmt --update
Found 20 Concept Exercises and 133 Practice Exercises in E:\repos\java\config.json
Looking for exercises that lack a formatted '.meta/config.json', '.approaches/config.json'
or '.articles/config.json' file...
Every exercise config is already formatted!

If you look at the output of the Configlet CI action, you can see the error:

The `files` array contains value `src/main/java/GameStates.java` but `/home/runner/work/java/java/exercises/practice/state-of-tic-tac-toe/src/main/java/GameStates.java` could not be found:
/home/runner/work/java/java/exercises/practice/state-of-tic-tac-toe/.meta/config.json

@manumafe98
Copy link
Copy Markdown
Contributor Author

The configlet start to fail again, that's weird

/e/repos/java (AddStateOfTicTacToePracticeExercise)
$ bin/configlet fmt --update
Found 20 Concept Exercises and 133 Practice Exercises in E:\repos\java\config.json
Looking for exercises that lack a formatted '.meta/config.json', '.approaches/config.json'
or '.articles/config.json' file...
Every exercise config is already formatted!

If you look at the output of the Configlet CI action, you can see the error:

The `files` array contains value `src/main/java/GameStates.java` but `/home/runner/work/java/java/exercises/practice/state-of-tic-tac-toe/src/main/java/GameStates.java` could not be found:
/home/runner/work/java/java/exercises/practice/state-of-tic-tac-toe/.meta/config.json

Oh yeah, sry that was an easy fix, going for it

Copy link
Copy Markdown
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@sanderploegsma sanderploegsma merged commit bea1013 into exercism:main Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/large Large amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new practice exercise: state-of-tic-tac-toe

2 participants