Run tests using java-test-runner#2559
Merged
Merged
Conversation
8178764 to
00574ed
Compare
5671d82 to
0dcba04
Compare
Contributor
Author
|
I do wonder whether the trade-off is worth it, since this approach slows down the CI test job 2-3x compared to using Gradle. |
ErikSchierboom
approved these changes
Nov 8, 2023
ErikSchierboom
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by this forum topic: https://forum.exercism.org/t/re-using-the-test-runners-in-corresponding-track-ci-jobs/8070.
Note that this required some updates to some of the exercises, particularly ones where not all files that are part of the example solution were correctly listed in the exercise's
config.json.The Mazy Mice exercise required a small change because of a compilation error due to a class being defined in both the example solution as well as the tests. Not sure why this wasn't caught when using the tests with Gradle. It shouldn't impact students though.
Reviewer Resources:
Track Policies