Switch to AssertJ (#2147)#2512
Conversation
# Conflicts: # exercises/practice/error-handling/src/test/java/ErrorHandlingTest.java
# Conflicts: # exercises/practice/error-handling/src/test/java/ErrorHandlingTest.java
…e/exercism_java into switch-to-assertj-for-exceptions
Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>
Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>
…e/exercism_java into switch-to-assertj-for-exceptions
|
Thanks for opening this PR! Next to the conflicts with #2511 which was merged I also see that you're including a lot of commits that have been merged as part of other PRs in the last weeks, causing the diff to be way larger. Looking at the latest commits I see you updated these four exercises, correct?
I believe that 2. and 4. have been resolved by #2511 and 1. is actually a deprecated exercise (which we don't update anymore). That just leaves 3. Could you maybe open a new PR that just updates the Zipper exercise? I suggest making sure that the |
|
Sure can do. I simple re-used the branch that I used for the previous PRs. I didn't expect the already merged commits to pop up again. Just two questions:
|
Yeah we use 'squash and merge' on PRs so all commits get collapsed into one. That unfortunately means that you'd have to rebase existing branches to get the history correct. Easiest is to always start fresh!
Yes. Deprecated exercises are not supposed to be touched after deprecation, so no update needed there.
There's no strict guidelines on that, but since every change to an exercise's Java code triggers new test runs of submitted solutions the answer is "not too many". I'd personally aim for no more than 10-20, to also keep the PRs relatively small and easy to review. |
pull request
Use AssertJ in more exercises. Might be in partial conflict with #2511
Reviewer Resources:
Track Policies