Skip to content

Update tests to use assertj (#2147)#2510

Merged
sanderploegsma merged 5 commits into
exercism:mainfrom
pavanbaloju:update-tests-to-assertj
Oct 5, 2023
Merged

Update tests to use assertj (#2147)#2510
sanderploegsma merged 5 commits into
exercism:mainfrom
pavanbaloju:update-tests-to-assertj

Conversation

@pavanbaloju
Copy link
Copy Markdown
Contributor

@pavanbaloju pavanbaloju commented Oct 5, 2023

pull request for (#2147 )

Hi @sanderploegsma, I have updated the following tests in this PR. Please review!

  1. CollatzCalculatorTest.java
  2. CryptoSquareTest.java
  3. DartsTest.java
  4. DifferenceOfSquaresCalculatorTest.java
  5. DiffieHellmanTest.java
  6. DnDCharacterTest.java
  7. DominoesTest.java
  8. ProteinTranslatorTest.java
  9. RotationalCipherTest.java

Reviewer Resources:

Track Policies

Copy link
Copy Markdown
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark to take care of, the rest of the changes look good to me!

@sanderploegsma sanderploegsma added the x:size/small Small amount of work label Oct 5, 2023
Copy link
Copy Markdown
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for your contribution!

@pavanbaloju
Copy link
Copy Markdown
Contributor Author

Nice work, thanks for your contribution!

Thanks for the oppurtunity!

@sanderploegsma sanderploegsma merged commit edb5725 into exercism:main Oct 5, 2023
@pavanbaloju pavanbaloju deleted the update-tests-to-assertj branch October 5, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/small Small amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants