Skip to content

Compile starter source with tests#2347

Merged
sanderploegsma merged 15 commits into
mainfrom
ci/compile-starter-source-with-tests
Sep 2, 2023
Merged

Compile starter source with tests#2347
sanderploegsma merged 15 commits into
mainfrom
ci/compile-starter-source-with-tests

Conversation

@sanderploegsma
Copy link
Copy Markdown
Contributor

This updates the Gradle build configuration to enable us to check whether the starter sources are able to compile with the unit tests. Hopefully this can help students by making sure that the code they receive for each exercise is able to compile without errors from the start, as figuring out why the tests don't compile is out of scope wrt learning on Exercism IMO.

Note that this PR is depending on each exercise having valid stubs, which are being added as part of #2133.


Reviewer Resources:

Track Policies

@sanderploegsma sanderploegsma force-pushed the ci/compile-starter-source-with-tests branch from bbc7b11 to 90ca020 Compare August 29, 2023 07:36
@sanderploegsma
Copy link
Copy Markdown
Contributor Author

The final two failures should be resolved after #2345 and #2346 are merged.

@sanderploegsma sanderploegsma marked this pull request as ready for review September 1, 2023 16:49
@sanderploegsma sanderploegsma requested review from a team and SleeplessByte September 1, 2023 16:50
Copy link
Copy Markdown
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change.

@sanderploegsma sanderploegsma merged commit 3120f4f into main Sep 2, 2023
@sanderploegsma sanderploegsma deleted the ci/compile-starter-source-with-tests branch September 2, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants