Add react exercise#2266
Merged
Merged
Conversation
sanderploegsma
requested changes
Sep 19, 2023
Contributor
sanderploegsma
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I left a couple of inline comments, but overall it already looks very good.
- Remove unneeded generics parameter - Remove unneeded projectsEvaluated config from gradle.build - Add ComputeCell stub for student - Change stubs to use interface instead of static inner classes - Update config.json to use prerequisites and practices instead of topics
sanderploegsma
requested changes
Sep 20, 2023
Contributor
sanderploegsma
left a comment
There was a problem hiding this comment.
That already looks a lot better!
I have one more comment about the exercise's configuration which should be addressed. The other comments on the reference implementation are a bit more subjective, so since you're the author of this exercise I leave it up to you to decide. In case you don't agree with my comments just let me know and resolve them.
* Refactor to example solution to propagate changes instead of tracking a tentative value and requiring a separate commit step. This approach is more consistent with the example solution in other tracks for this exercise. * Change Cells to use just inner classes instead of interfaces.
sanderploegsma
approved these changes
Sep 22, 2023
Contributor
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request
Add react exercise.
Closes #1815
Reviewer Resources:
Track Policies