From aed9a1ae85866aa2dc57578c80f8c1001fa32671 Mon Sep 17 00:00:00 2001 From: Rodrigo Oscar Gonzalez Date: Sat, 18 Feb 2023 10:54:38 +0100 Subject: [PATCH 1/2] Removing itShouldReturnZeroIfBirdWatcherLastWeekIsEmpty() test from BirdWatcherTest.java --- .../bird-watcher/src/test/java/BirdWatcherTest.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java b/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java index 355bceaef..d56a2ae76 100644 --- a/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java +++ b/exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java @@ -33,13 +33,6 @@ public void itTestGetToday() { assertThat(birdWatcher.getToday()).isEqualTo(TODAY); } - @Test - public void itShouldReturnZeroIfBirdWatcherLastWeekIsEmpty() { - int[] lastWeekEmpty = new int[0]; - birdWatcher = new BirdWatcher(lastWeekEmpty); - assertThat(birdWatcher.getToday()).isEqualTo(0); - } - @Test public void itIncrementTodaysCount() { birdWatcher.incrementTodaysCount(); From 1d01e44f450230527e33f824c55d1decd3962e7b Mon Sep 17 00:00:00 2001 From: Rodrigo Oscar Gonzalez Date: Sat, 18 Feb 2023 11:06:47 +0100 Subject: [PATCH 2/2] Removing check against zero length since there is a precondition of having 7 elements in the array --- .../bird-watcher/.meta/src/reference/java/BirdWatcher.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/exercises/concept/bird-watcher/.meta/src/reference/java/BirdWatcher.java b/exercises/concept/bird-watcher/.meta/src/reference/java/BirdWatcher.java index a1729fc51..4d7d3c040 100644 --- a/exercises/concept/bird-watcher/.meta/src/reference/java/BirdWatcher.java +++ b/exercises/concept/bird-watcher/.meta/src/reference/java/BirdWatcher.java @@ -11,9 +11,6 @@ public int[] getLastWeek() { } public int getToday() { - if (birdsPerDay.length == 0) { - return 0; - } return birdsPerDay[birdsPerDay.length - 1]; }