2257 birds watcher remove test#2265
Merged
andrerfcsantos merged 3 commits intoFeb 27, 2023
Merged
Conversation
…irdWatcherTest.java
…aving 7 elements in the array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request
Closes #2257
Since the pre-condition for the exercise is that we have a fixed number of elements in the array there should not be a test checking for an empty array. Having that test will prevent some valid solutions not to pass.
Two files have been modified:
exercises/concept/bird-watcher/src/test/java/BirdWatcherTest.java: removing the conflicting test
exercises/concept/bird-watcher/.meta/src/reference/java/BirdWatcher.java: removing the check for a length of zero in the reference code since that check is not necessary
Reviewer Resources:
Track Policies