Converting tests to AssertJ (exercises starting with H, I, K)#2052
Merged
Conversation
Also updating reference implementation, removing unnecessary reference to ArrayList.
mirkoperillo
approved these changes
Nov 2, 2021
Contributor
mirkoperillo
left a comment
There was a problem hiding this comment.
thank you @thtroyer LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw someone else group their AssertJ conversions together and figured I'd start doing the same.
The tests have been converted from using JUnit's assertions to use AssertJ, cleaning up and inlining portions of the tests that make sense to do so.
I also updated the reference implementation for knapsack. It needlessly specified ArrayList in its method signatures (instead of just List). Switching to List let me clean up the tests a little more.
Exercises updated:
Reviewer Resources:
Track Policies