Introduce assertj in resistor-color exercise #1984
Merged
Merged
Conversation
jmrunkle
reviewed
Sep 4, 2021
| String[] expected = {"black", "brown", "red", "orange", "yellow", "green", "blue", "violet", "grey", "white"}; | ||
|
|
||
| assertArrayEquals(expected, resistorColor.colors()); | ||
| assertThat(resistorColor.colors()).isEqualTo( |
Contributor
There was a problem hiding this comment.
isEqualTo is probably the wrong assertion for an array. We want containsExactly behavior.
Contributor
Author
There was a problem hiding this comment.
Good catch. I'll fix it.
jmrunkle
approved these changes
Sep 4, 2021
Contributor
jmrunkle
left a comment
There was a problem hiding this comment.
This looks good aside from the possible style violation.
| String[] expected = {"black", "brown", "red", "orange", "yellow", "green", "blue", "violet", "grey", "white"}; | ||
|
|
||
| assertArrayEquals(expected, resistorColor.colors()); | ||
| assertThat(resistorColor.colors()).containsExactly("black", "brown", "red", "orange", "yellow", "green", "blue", "violet", "grey", "white"); |
Contributor
There was a problem hiding this comment.
This might not pass style checks, but I am working on getting that workflow re-enabled: #1988
Contributor
Author
There was a problem hiding this comment.
Can I view the style guidelines somewhere?
Contributor
Author
There was a problem hiding this comment.
Nevermind. I found the gradle check command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request
For issue #1982
Converting junit assertions into AssertJ assertions and ran tests against the reference implementation.
Let me know if there are any issues. I opted to use concise assertion statements as I feel AssertJ is more readable with them.
Reviewer Resources:
Track Policies