🤖 Update tests.toml files to latest spec#1893
Merged
mirkoperillo merged 1 commit intoFeb 26, 2021
Merged
Conversation
Track maintainers found that they wanted to add comments to the tests.toml file to e.g. indicate _why_ a test was not included. Unfortunately, running configlet sync would re-generate the entire file so any manually added comments were lost. In this commit we're updating the format of tests.toml files to support adding comments. We do this by creating a separate table for each test case which has `description` and `include` fields. Tracks are then free to add additional fields, like a `comment` field, but also anything they feel might be useful to them. For more information, see this discussion: exercism/configlet#186
mirkoperillo
approved these changes
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Track maintainers found that they wanted to add comments to the tests.toml file to e.g. indicate why a test was not included.
Unfortunately, running configlet sync would re-generate the entire file so any manually added comments were lost.
In this PR we're updating the format of tests.toml files to support adding comments.
We do this by creating a separate table for each test case which has
descriptionandincludefields.Tracks are then free to add additional fields, like a
commentfield, but also any other fields they feel might be useful to them.configlet has not yet been updated to support this new format, but we hope to do this soon. Sorry for the inconvenience.
For more information, see this discussion: exercism/configlet#186
Implementation
The PR expects the tests.toml files to be in their original format:
This is transformed to:
Example
becomes
Existing comments
As some tracks have manually added comments to tests, we try to detect them by assuming they are either:
For any such manually detected comments, we'll add a
commentfield.Tracking
exercism/v3-launch#22