Fixed bugs (#103)

realDuYuanChao · github-actions · web-flow · commit 867f2f89385f · 2021-04-12T17:30:45.000+08:00
* fixed binary search

* fixed find max/min bugs

* Formatted with Google Java Formatter

Co-authored-by: github-actions &lt;${GITHUB_ACTOR}@users.noreply.github.com&gt;
diff --git a/src/main/java/com/examplehub/maths/FindMaxRecursion.java b/src/main/java/com/examplehub/maths/FindMaxRecursion.java
@@ -29,7 +29,7 @@ public static int max(int[] numbers, int left, int right) {
     if (left == right) {
       return numbers[left];
     }
-    int middle = (left + right) >> 1;
+    int middle = left + (right - left) / 2;
     int leftMax = max(numbers, left, middle); /* find max in range[left, middle] */
     int rightMax = max(numbers, middle + 1, right); /* find max in range[middle + 1, right] */
     return Math.max(leftMax, rightMax);
diff --git a/src/main/java/com/examplehub/maths/FindMinRecursion.java b/src/main/java/com/examplehub/maths/FindMinRecursion.java
@@ -29,7 +29,7 @@ public static int min(int[] numbers, int left, int right) {
     if (right == left) {
       return numbers[right];
     }
-    int middle = (left + right) >> 1;
+    int middle = left + (right - left) / 2;
     int leftMin = min(numbers, left, middle); /* find min in range[left, middle] */
     int rightMin = min(numbers, middle + 1, right); /* find min in range[middle + 1, right] */
     return Math.min(leftMin, rightMin);
diff --git a/src/main/java/com/examplehub/searches/BinarySearch.java b/src/main/java/com/examplehub/searches/BinarySearch.java
@@ -14,7 +14,7 @@ public int search(int[] numbers, int key) {
     int left = 0;
     int right = numbers.length - 1;
     while (left <= right) {
-      int mid = (left + right) >> 1;
+      int mid = left + (right - left) / 2;
       if (key == numbers[mid]) {
         return mid;
       } else if (key > numbers[mid]) {
@@ -39,7 +39,7 @@ public <T extends Comparable<T>> int search(T[] array, T key) {
     int left = 0;
     int right = array.length - 1;
     while (left <= right) {
-      int mid = (left + right) >> 1;
+      int mid = left + (right - left) / 2;
       if (key.compareTo(array[mid]) == 0) {
         return mid;
       } else if (key.compareTo(array[mid]) > 0) {
diff --git a/src/main/java/com/examplehub/searches/BinarySearchRecursion.java b/src/main/java/com/examplehub/searches/BinarySearchRecursion.java
@@ -20,7 +20,7 @@ public int search(int[] numbers, int left, int right, int key) {
     if (left > right) {
       return -1;
     }
-    int mid = (left + right) >> 1;
+    int mid = left + (right - left) / 2;
     if (key == numbers[mid]) {
       return mid;
     } else if (key >= numbers[mid]) {
@@ -49,7 +49,7 @@ public <T extends Comparable<T>> int search(T[] array, int left, int right, T ke
     if (left > right) {
       return -1;
     }
-    int mid = (left + right) >> 1;
+    int mid = left + (right - left) / 2;
     if (key.compareTo(array[mid]) == 0) {
       return mid;
     } else if (key.compareTo(array[mid]) > 0) {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public static int max(int[] numbers, int left, int right) {`
`29`	`29`	`if (left == right) {`
`30`	`30`	`return numbers[left];`
`31`	`31`	`}`
`32`		`- int middle = (left + right) >> 1;`
	`32`	`+ int middle = left + (right - left) / 2;`
`33`	`33`	`int leftMax = max(numbers, left, middle); /* find max in range[left, middle] */`
`34`	`34`	`int rightMax = max(numbers, middle + 1, right); /* find max in range[middle + 1, right] */`
`35`	`35`	`return Math.max(leftMax, rightMax);`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public static int min(int[] numbers, int left, int right) {`
`29`	`29`	`if (right == left) {`
`30`	`30`	`return numbers[right];`
`31`	`31`	`}`
`32`		`- int middle = (left + right) >> 1;`
	`32`	`+ int middle = left + (right - left) / 2;`
`33`	`33`	`int leftMin = min(numbers, left, middle); /* find min in range[left, middle] */`
`34`	`34`	`int rightMin = min(numbers, middle + 1, right); /* find min in range[middle + 1, right] */`
`35`	`35`	`return Math.min(leftMin, rightMin);`