test: use "semver" module, disable the HTTPS over HTTPS test for node >= v0.11.3

TooTallNate · TooTallNate · commit 3161870c755f · 2013-09-16T12:18:17.000-07:00
For now... See: nodejs/node-v0.x-archive#6204
diff --git a/package.json b/package.json
@@ -28,6 +28,7 @@
   },
   "devDependencies": {
     "mocha": "~1.12.0",
-    "proxy": "~0.2.0"
+    "proxy": "~0.2.0",
+    "semver": "~2.1.0"
   }
 }
diff --git a/test/test.js b/test/test.js
@@ -9,6 +9,8 @@ var http = require('http');
 var https = require('https');
 var assert = require('assert');
 var Proxy = require('proxy');
+var Semver = require('semver');
+var version = new Semver(process.version);
 var HttpsProxyAgent = require('../');
 
 describe('HttpsProxyAgent', function () {
@@ -204,36 +206,43 @@ describe('HttpsProxyAgent', function () {
         });
       });
     });
-    it('should work over an HTTPS proxy', function (done) {
-      // set HTTP "request" event handler for this test
-      sslServer.once('request', function (req, res) {
-        res.end(JSON.stringify(req.headers));
-      });
-
-      var proxy = process.env.HTTPS_PROXY || process.env.https_proxy || 'https://127.0.0.1:' + sslProxyPort;
-      proxy = url.parse(proxy);
-      // `rejectUnauthorized` is actually necessary this time since the HTTPS
-      // proxy server itself is using a self-signed SSL certificate…
-      proxy.rejectUnauthorized = false;
-      var agent = new HttpsProxyAgent(proxy);
 
-      var opts = url.parse('https://127.0.0.1:' + sslServerPort);
-      opts.agent = agent;
-      opts.rejectUnauthorized = false;
+    if (version.compare('0.11.3') < 0) {
+      // This test is disabled on node >= 0.11.3, since it currently segfaults :(
+      // See: https://github.com/joyent/node/issues/6204
 
-      https.get(opts, function (res) {
-        var data = '';
-        res.setEncoding('utf8');
-        res.on('data', function (b) {
-          data += b;
+      it('should work over an HTTPS proxy', function (done) {
+        // set HTTP "request" event handler for this test
+        sslServer.once('request', function (req, res) {
+          res.end(JSON.stringify(req.headers));
         });
-        res.on('end', function () {
-          data = JSON.parse(data);
-          assert.equal('127.0.0.1:' + sslServerPort, data.host);
-          done();
+
+        var proxy = process.env.HTTPS_PROXY || process.env.https_proxy || 'https://127.0.0.1:' + sslProxyPort;
+        proxy = url.parse(proxy);
+        // `rejectUnauthorized` is actually necessary this time since the HTTPS
+        // proxy server itself is using a self-signed SSL certificate…
+        proxy.rejectUnauthorized = false;
+        var agent = new HttpsProxyAgent(proxy);
+
+        var opts = url.parse('https://127.0.0.1:' + sslServerPort);
+        opts.agent = agent;
+        opts.rejectUnauthorized = false;
+
+        https.get(opts, function (res) {
+          var data = '';
+          res.setEncoding('utf8');
+          res.on('data', function (b) {
+            data += b;
+          });
+          res.on('end', function () {
+            data = JSON.parse(data);
+            assert.equal('127.0.0.1:' + sslServerPort, data.host);
+            done();
+          });
         });
       });
-    });
+    }
+
   });
 
 });

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`	`},`
`29`	`29`	`"devDependencies": {`
`30`	`30`	`"mocha": "~1.12.0",`
`31`		`- "proxy": "~0.2.0"`
	`31`	`+ "proxy": "~0.2.0",`
	`32`	`+ "semver": "~2.1.0"`
`32`	`33`	`}`
`33`	`34`	`}`