Merge pull request eugenp#6260 from alimate/BAEL-2658

eric-martin · web-flow · commit 4ba3b740d659 · 2019-02-08T23:30:27.000-06:00
Refactored the test names and used backtick identifiers.
diff --git a/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/CalculatorTest5.kt b/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/CalculatorTest5.kt
@@ -7,12 +7,12 @@ class CalculatorTest5 {
     private val calculator = Calculator()
 
     @Test
-    fun whenAdding1and3_thenAnswerIs4() {
+    fun `Adding 1 and 3 should be eqaul to 4`() {
         Assertions.assertEquals(4, calculator.add(1, 3))
     }
 
     @Test
-    fun whenDividingBy0_thenErrorOccurs() {
+    fun `Dividing by zero should throw the DivideByZeroException`() {
         val exception = Assertions.assertThrows(DivideByZeroException::class.java) {
             calculator.divide(5, 0)
         }
@@ -21,7 +21,7 @@ class CalculatorTest5 {
     }
 
     @Test
-    fun whenSquaringNumbers_thenCorrectAnswerGiven() {
+    fun `The square of a number should be eqaul to that number multiplied in itself`() {
         Assertions.assertAll(
                 Executable { Assertions.assertEquals(1, calculator.square(1)) },
                 Executable { Assertions.assertEquals(4, calculator.square(2)) },
@@ -76,7 +76,7 @@ class CalculatorTest5 {
             Tag("logarithms")
     )
     @Test
-    fun whenIcalculateLog2Of8_thenIget3() {
+    fun `Log to base 2 of 8 should be equal to 3`() {
         Assertions.assertEquals(3.0, calculator.log(2, 8))
     }
 }
diff --git a/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/SimpleTest5.kt b/core-kotlin/src/test/kotlin/com/baeldung/kotlin/junit5/SimpleTest5.kt
@@ -5,15 +5,16 @@ import org.junit.jupiter.api.Disabled
 import org.junit.jupiter.api.Test
 
 class SimpleTest5 {
+
     @Test
-    fun whenEmptyList_thenListIsEmpty() {
+    fun `isEmpty should return true for empty lists`() {
         val list = listOf<String>()
         Assertions.assertTrue(list::isEmpty)
     }
 
     @Test
     @Disabled
-    fun when3equals4_thenTestFails() {
+    fun `3 is equal to 4`() {
         Assertions.assertEquals(3, 4) {
             "Three does not equal four"
         }

Original file line number	Diff line number	Diff line change
`@@ -7,12 +7,12 @@ class CalculatorTest5 {`
`7`	`7`	`private val calculator = Calculator()`
`8`	`8`
`9`	`9`	`@Test`
`10`		`- fun whenAdding1and3_thenAnswerIs4() {`
	`10`	+ fun `Adding 1 and 3 should be eqaul to 4`() {
`11`	`11`	`Assertions.assertEquals(4, calculator.add(1, 3))`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`@Test`
`15`		`- fun whenDividingBy0_thenErrorOccurs() {`
	`15`	+ fun `Dividing by zero should throw the DivideByZeroException`() {
`16`	`16`	`val exception = Assertions.assertThrows(DivideByZeroException::class.java) {`
`17`	`17`	`calculator.divide(5, 0)`
`18`	`18`	`}`
`@@ -21,7 +21,7 @@ class CalculatorTest5 {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`@Test`
`24`		`- fun whenSquaringNumbers_thenCorrectAnswerGiven() {`
	`24`	+ fun `The square of a number should be eqaul to that number multiplied in itself`() {
`25`	`25`	`Assertions.assertAll(`
`26`	`26`	`Executable { Assertions.assertEquals(1, calculator.square(1)) },`
`27`	`27`	`Executable { Assertions.assertEquals(4, calculator.square(2)) },`
`@@ -76,7 +76,7 @@ class CalculatorTest5 {`
`76`	`76`	`Tag("logarithms")`
`77`	`77`	`)`
`78`	`78`	`@Test`
`79`		`- fun whenIcalculateLog2Of8_thenIget3() {`
	`79`	+ fun `Log to base 2 of 8 should be equal to 3`() {
`80`	`80`	`Assertions.assertEquals(3.0, calculator.log(2, 8))`
`81`	`81`	`}`
`82`	`82`	`}`