Fix call to "off" when MoveJoystick.on is called with joystick centered (#578)

WasabiFan · web-flow · commit 056f721c383a · 2018-12-19T00:36:53.000-08:00
* Fix call to "off" when MoveJoystick.on is called with joystick centered Fixes #575
diff --git a/ev3dev2/motor.py b/ev3dev2/motor.py
@@ -2214,7 +2214,7 @@ def on(self, x, y, radius=100.0):
 
         # If joystick is in the middle stop the tank
         if not x and not y:
-            MoveTank.off()
+            self.off()
             return
 
         vector_length = sqrt(x*x + y*y)
diff --git a/tests/api_tests.py b/tests/api_tests.py
@@ -316,7 +316,7 @@ def test_steering_large_value(self):
         self.assertEqual(drive.right_motor.position_sp, 10 * 360)
         self.assertEqual(drive.right_motor.speed_sp, 400)
 
-    def test_joystick_units(self):
+    def test_joystick(self):
         clean_arena()
         populate_arena([('large_motor', 0, 'outA'), ('large_motor', 1, 'outB')])
 
@@ -327,6 +327,13 @@ def test_joystick_units(self):
         drive.on(0, 50)
         self.assertEqual(drive.left_motor.speed_sp, 1050 / 2)
         self.assertEqual(drive.right_motor.speed_sp, 1050 / 2)
+        self.assertEqual(drive.left_motor._get_attribute(None, 'command')[1], 'run-forever')
+        self.assertEqual(drive.right_motor._get_attribute(None, 'command')[1], 'run-forever')
+
+        # With the joystick centered, motors should both be stopped
+        drive.on(0, 0)
+        self.assertEqual(drive.left_motor._get_attribute(None, 'command')[1], 'stop')
+        self.assertEqual(drive.right_motor._get_attribute(None, 'command')[1], 'stop')
 
     def test_units(self):
         clean_arena()
