-
-
Notifications
You must be signed in to change notification settings - Fork 5k
CR - max-len: {ignoreRegExpLiterals: true} is too permissive #9059
Copy link
Copy link
Closed
Labels
archived due to ageThis issue has been archived; please open a new issue for any further discussionThis issue has been archived; please open a new issue for any further discussionbreakingThis change is backwards-incompatibleThis change is backwards-incompatibleenhancementThis change enhances an existing feature of ESLintThis change enhances an existing feature of ESLintevaluatingThe team will evaluate this issue to decide whether it meets the criteria for inclusionThe team will evaluate this issue to decide whether it meets the criteria for inclusionruleRelates to ESLint's core rulesRelates to ESLint's core rules
Metadata
Metadata
Assignees
Labels
archived due to ageThis issue has been archived; please open a new issue for any further discussionThis issue has been archived; please open a new issue for any further discussionbreakingThis change is backwards-incompatibleThis change is backwards-incompatibleenhancementThis change enhances an existing feature of ESLintThis change enhances an existing feature of ESLintevaluatingThe team will evaluate this issue to decide whether it meets the criteria for inclusionThe team will evaluate this issue to decide whether it meets the criteria for inclusionruleRelates to ESLint's core rulesRelates to ESLint's core rules
Tell us about your environment
4.3.0master5.3.0What parser (default, Babel-ESLint, etc.) are you using?
N/A
Please show your full configuration:
https://github.com/nodejs/node/blob/master/.eslintrc.yaml
https://github.com/nodejs/node/blob/master/lib/.eslintrc.yaml
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
L09 should error.
Even though we have
ignoreRegExpLiterals: truesuch cases should not be allowed. It's not the RegExp that is super long, it's the multiple expressions in that single line that caused it to be too long.I understand it's not a straightforward problem to solve, but IMHO it could be minimized with some heuristics.
What actually happened? Please include the actual, raw output from ESLint.
Nothing (i.e. lint passed)