feat: apply fix for no-var in TSModuleBlock (#20638)

Tanujkanti4441 · web-flow · commit ff4382be3490 · 2026-03-19T17:25:59.000+01:00
diff --git a/lib/rules/no-var.js b/lib/rules/no-var.js
@@ -319,6 +319,10 @@ module.exports = {
 		function canFix(node) {
 			const variables = sourceCode.getDeclaredVariables(node);
 			const scopeNode = getScopeNode(node);
+			const parentStatementList = new Set([
+				...astUtils.STATEMENT_LIST_PARENTS,
+				"TSModuleBlock",
+			]);
 
 			if (
 				node.parent.type === "SwitchCase" ||
@@ -347,7 +351,7 @@ module.exports = {
 					node.parent.type === "ForStatement" &&
 					node.parent.init === node
 				) &&
-				!astUtils.STATEMENT_LIST_PARENTS.has(node.parent.type)
+				!parentStatementList.has(node.parent.type)
 			) {
 				// If the declaration is not in a block, e.g. `if (foo) var bar = 1;`, then it can't be fixed.
 				return false;
diff --git a/tests/lib/rules/no-var.js b/tests/lib/rules/no-var.js
@@ -517,12 +517,19 @@ const ruleTesterTypeScript = new RuleTester({
 ruleTesterTypeScript.run("no-var", rule, {
 	valid: ["declare global { var bar: 'car' }"],
 	invalid: [
+		{
+			code: "declare var x: number",
+			output: "declare let x: number",
+			errors: [{ messageId: "unexpectedVar" }],
+		},
 		{
 			code: "declare namespace ns { var bar: 'car' }",
+			output: "declare namespace ns { let bar: 'car' }",
 			errors: [{ messageId: "unexpectedVar" }],
 		},
 		{
 			code: "declare module 'module' { var bar: 'car' }",
+			output: "declare module 'module' { let bar: 'car' }",
 			errors: [{ messageId: "unexpectedVar" }],
 		},
 	],
