feat: fix no-useless-computed-key false negative with __proto__ (#19123)

mdjermanovic · web-flow · commit bdec50e91baf · 2024-11-13T10:29:16.000-05:00
diff --git a/lib/rules/no-useless-computed-key.js b/lib/rules/no-useless-computed-key.js
@@ -58,7 +58,10 @@ function hasUselessComputedKey(node) {
 
     switch (node.type) {
         case "Property":
-            return value !== "__proto__";
+            if (node.parent.type === "ObjectExpression") {
+                return value !== "__proto__";
+            }
+            return true;
 
         case "PropertyDefinition":
             if (node.static) {
diff --git a/tests/lib/rules/no-useless-computed-key.js b/tests/lib/rules/no-useless-computed-key.js
@@ -29,10 +29,6 @@ ruleTester.run("no-useless-computed-key", rule, {
         "var { a } = obj;",
         "var { a: a } = obj;",
         "var { a: b } = obj;",
-
-        // ['__proto__'] is useless computed key in object patterns, but the rule doesn't report it for backwards compatibility since it's frozen
-        "var { ['__proto__']: a } = obj",
-
         { code: "class Foo { a() {} }", options: [{ enforceForClassMembers: true }] },
         { code: "class Foo { 'a'() {} }", options: [{ enforceForClassMembers: true }] },
         { code: "class Foo { [x]() {} }", options: [{ enforceForClassMembers: true }] },
@@ -121,6 +117,14 @@ ruleTester.run("no-useless-computed-key", rule, {
                 data: { property: "'x'" },
                 type: "Property"
             }]
+        }, {
+            code: "var { ['__proto__']: a } = obj",
+            output: "var { '__proto__': a } = obj",
+            errors: [{
+                messageId: "unnecessarilyComputedProperty",
+                data: { property: "'__proto__'" },
+                type: "Property"
+            }]
         }, {
             code: "({ ['x']() {} })",
             output: "({ 'x'() {} })",
