Update: Drop @typescript-eslint/eslint-recommended from eslint --init (#13340)

NMinhNguyen · web-flow · commit 6cfbd03b3f22 · 2020-06-11T19:14:28.000-04:00
`@typescript-eslint/recommended` now extends from `@typescript-eslint/eslint-recommended`: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0
diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js
@@ -321,7 +321,6 @@ function processAnswers(answers) {
         }
     }
     if (answers.typescript && config.extends.includes("eslint:recommended")) {
-        config.extends.push("plugin:@typescript-eslint/eslint-recommended");
         config.extends.push("plugin:@typescript-eslint/recommended");
     }
 
diff --git a/tests/lib/init/config-initializer.js b/tests/lib/init/config-initializer.js
@@ -174,15 +174,15 @@ describe("configInitializer", () => {
 
                 assert.strictEqual(config.parser, "@typescript-eslint/parser");
                 assert.deepStrictEqual(config.plugins, ["@typescript-eslint"]);
-                assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]);
+                assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:@typescript-eslint/recommended"]);
             });
 
             it("should enable typescript parser and plugin with vue", () => {
                 answers.framework = "vue";
                 answers.typescript = true;
                 const config = init.processAnswers(answers);
 
-                assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential", "plugin:@typescript-eslint/eslint-recommended", "plugin:@typescript-eslint/recommended"]);
+                assert.deepStrictEqual(config.extends, ["eslint:recommended", "plugin:vue/essential", "plugin:@typescript-eslint/recommended"]);
                 assert.strictEqual(config.parserOptions.parser, "@typescript-eslint/parser");
                 assert.deepStrictEqual(config.plugins, ["vue", "@typescript-eslint"]);
             });

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,6 @@ function processAnswers(answers) {`
`321`	`321`	`}`
`322`	`322`	`}`
`323`	`323`	`if (answers.typescript && config.extends.includes("eslint:recommended")) {`
`324`		`- config.extends.push("plugin:@typescript-eslint/eslint-recommended");`
`325`	`324`	`config.extends.push("plugin:@typescript-eslint/recommended");`
`326`	`325`	`}`
`327`	`326`