Chore: update no-unused-vars caughtErrors in eslint-config-eslint (#13351)

mdjermanovic · web-flow · commit 578efad331b7 · 2020-06-01T15:05:01.000-04:00
diff --git a/lib/cli-engine/cli-engine.js b/lib/cli-engine/cli-engine.js
@@ -403,7 +403,7 @@ function getCacheFile(cacheFile, cwd) {
 
     try {
         fileStats = fs.lstatSync(resolvedCacheFile);
-    } catch (ex) {
+    } catch {
         fileStats = null;
     }
 
@@ -991,7 +991,7 @@ class CLIEngine {
                     const npmFormat = naming.normalizePackageName(normalizedFormatName, "eslint-formatter");
 
                     formatterPath = ModuleResolver.resolve(npmFormat, path.join(cwd, "__placeholder__.js"));
-                } catch (e) {
+                } catch {
                     formatterPath = path.resolve(__dirname, "formatters", normalizedFormatName);
                 }
             }
diff --git a/lib/cli-engine/config-array-factory.js b/lib/cli-engine/config-array-factory.js
@@ -517,7 +517,7 @@ class ConfigArrayFactory {
                     try {
                         loadPackageJSONConfigFile(filePath);
                         return filePath;
-                    } catch (error) { /* ignore */ }
+                    } catch { /* ignore */ }
                 } else {
                     return filePath;
                 }
diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js
@@ -350,7 +350,7 @@ function getLocalESLintVersion() {
         const eslint = require(eslintPath);
 
         return eslint.linter.version || null;
-    } catch (_err) {
+    } catch {
         return null;
     }
 }
diff --git a/lib/linter/config-comment-parser.js b/lib/linter/config-comment-parser.js
@@ -78,7 +78,7 @@ module.exports = class ConfigCommentParser {
                     config: items
                 };
             }
-        } catch (ex) {
+        } catch {
 
             debug("Levn parsing failed; falling back to manual parsing.");
 
diff --git a/lib/rules/no-control-regex.js b/lib/rules/no-control-regex.js
@@ -35,7 +35,7 @@ const collector = new (class {
         try {
             this._source = regexpStr;
             this._validator.validatePattern(regexpStr); // Call onCharacter hook
-        } catch (err) {
+        } catch {
 
             // Ignore syntax errors in RegExp.
         }
diff --git a/lib/rules/no-invalid-regexp.js b/lib/rules/no-invalid-regexp.js
@@ -93,7 +93,7 @@ module.exports = {
             try {
                 validator.validateFlags(flags);
                 return null;
-            } catch (err) {
+            } catch {
                 return `Invalid flags supplied to RegExp constructor '${flags}'`;
             }
         }
diff --git a/lib/rules/no-misleading-character-class.js b/lib/rules/no-misleading-character-class.js
@@ -147,7 +147,7 @@ module.exports = {
                     pattern.length,
                     flags.includes("u")
                 );
-            } catch (e) {
+            } catch {
 
                 // Ignore regular expressions with syntax errors
                 return;
diff --git a/lib/rules/no-regex-spaces.js b/lib/rules/no-regex-spaces.js
@@ -76,7 +76,7 @@ module.exports = {
 
             try {
                 regExpAST = regExpParser.parsePattern(pattern, 0, pattern.length, flags.includes("u"));
-            } catch (e) {
+            } catch {
 
                 // Ignore regular expressions with syntax errors
                 return;
diff --git a/lib/rules/no-useless-backreference.js b/lib/rules/no-useless-backreference.js
@@ -95,7 +95,7 @@ module.exports = {
 
             try {
                 regExpAST = parser.parsePattern(pattern, 0, pattern.length, flags.includes("u"));
-            } catch (e) {
+            } catch {
 
                 // Ignore regular expressions with syntax errors
                 return;
diff --git a/lib/rules/prefer-named-capture-group.js b/lib/rules/prefer-named-capture-group.js
@@ -59,7 +59,7 @@ module.exports = {
 
             try {
                 ast = parser.parsePattern(pattern, 0, pattern.length, uFlag);
-            } catch (_) {
+            } catch {
 
                 // ignore regex syntax errors
                 return;
diff --git a/lib/rules/quote-props.js b/lib/rules/quote-props.js
@@ -154,7 +154,7 @@ module.exports = {
 
                 try {
                     tokens = espree.tokenize(key.value);
-                } catch (e) {
+                } catch {
                     return;
                 }
 
@@ -239,7 +239,7 @@ module.exports = {
 
                         try {
                             tokens = espree.tokenize(key.value);
-                        } catch (e) {
+                        } catch {
                             necessaryQuotes = true;
                             return;
                         }
diff --git a/lib/rules/utils/ast-utils.js b/lib/rules/utils/ast-utils.js
@@ -1415,7 +1415,7 @@ module.exports = {
 
             try {
                 tokens = espree.tokenize(leftValue, espreeOptions);
-            } catch (e) {
+            } catch {
                 return false;
             }
 
@@ -1444,7 +1444,7 @@ module.exports = {
 
             try {
                 tokens = espree.tokenize(rightValue, espreeOptions);
-            } catch (e) {
+            } catch {
                 return false;
             }
 
diff --git a/packages/eslint-config-eslint/default.yml b/packages/eslint-config-eslint/default.yml
@@ -134,7 +134,7 @@ rules:
     no-unmodified-loop-condition: "error"
     no-unneeded-ternary: "error"
     no-unused-expressions: "error"
-    no-unused-vars: ["error", {vars: "all", args: "after-used"}]
+    no-unused-vars: ["error", {vars: "all", args: "after-used", caughtErrors: "all"}]
     no-use-before-define: "error"
     no-useless-call: "error"
     no-useless-computed-key: "error"
diff --git a/tests/_utils/in-memory-fs.js b/tests/_utils/in-memory-fs.js
@@ -111,7 +111,7 @@ const context = vm.createContext();
 function isExistingFile(fs, filePath) {
     try {
         return fs.statSync(filePath).isFile();
-    } catch (error) {
+    } catch {
         return false;
     }
 }
diff --git a/tests/lib/cli-engine/cli-engine.js b/tests/lib/cli-engine/cli-engine.js
@@ -58,7 +58,7 @@ describe("CLIEngine", () => {
 
         try {
             return fs.realpathSync(filepath);
-        } catch (e) {
+        } catch {
             return filepath;
         }
     }
@@ -2161,7 +2161,7 @@ describe("CLIEngine", () => {
             function doDelete(filePath) {
                 try {
                     fs.unlinkSync(filePath);
-                } catch (ex) {
+                } catch {
 
                     /*
                      * we don't care if the file didn't exist, since our
@@ -2197,7 +2197,7 @@ describe("CLIEngine", () => {
                 function deleteCacheDir() {
                     try {
                         fs.unlinkSync("./tmp/.cacheFileDir/.cache_hashOfCurrentWorkingDirectory");
-                    } catch (ex) {
+                    } catch {
 
                         /*
                          * we don't care if the file didn't exist, since our
diff --git a/tests/lib/eslint/eslint.js b/tests/lib/eslint/eslint.js
@@ -55,7 +55,7 @@ describe("ESLint", () => {
 
         try {
             return fs.realpathSync(filepath);
-        } catch (e) {
+        } catch {
             return filepath;
         }
     }
@@ -2102,7 +2102,7 @@ describe("ESLint", () => {
             function doDelete(filePath) {
                 try {
                     fs.unlinkSync(filePath);
-                } catch (ex) {
+                } catch {
 
                     /*
                      * we don't care if the file didn't exist, since our
@@ -2138,7 +2138,7 @@ describe("ESLint", () => {
                 function deleteCacheDir() {
                     try {
                         fs.unlinkSync("./tmp/.cacheFileDir/.cache_hashOfCurrentWorkingDirectory");
-                    } catch (ex) {
+                    } catch {
 
                         /*
                          * we don't care if the file didn't exist, since our
diff --git a/tests/lib/init/config-initializer.js b/tests/lib/init/config-initializer.js
@@ -67,7 +67,7 @@ describe("configInitializer", () => {
 
         try {
             return fs.realpathSync(filepath);
-        } catch (e) {
+        } catch {
             return filepath;
         }
     }
diff --git a/tests/lib/init/source-code-utils.js b/tests/lib/init/source-code-utils.js
@@ -41,7 +41,7 @@ describe("SourceCodeUtil", () => {
         try {
             filepath = fs.realpathSync(filepath);
             return filepath;
-        } catch (e) {
+        } catch {
             return filepath;
         }
     }
diff --git a/tools/code-sample-minimizer.js b/tools/code-sample-minimizer.js
@@ -76,7 +76,7 @@ function reduceBadExampleSize({
     function reproducesBadCase(updatedSourceText) {
         try {
             parser.parse(updatedSourceText);
-        } catch (err) {
+        } catch {
             return false;
         }
 
diff --git a/tools/eslint-fuzzer.js b/tools/eslint-fuzzer.js
@@ -65,7 +65,7 @@ function fuzz(options) {
 
             try {
                 fixResult = linter.verifyAndFix(text, reducedConfig, {});
-            } catch (err) {
+            } catch {
                 return reducedConfig;
             }
 
@@ -91,7 +91,7 @@ function fuzz(options) {
 
             try {
                 messages = linter.verify(currentText, config);
-            } catch (err) {
+            } catch {
                 return currentText;
             }
 
@@ -150,7 +150,7 @@ function fuzz(options) {
                     try {
                         linter.verify(reducedText, smallConfig);
                         return false;
-                    } catch (_) {
+                    } catch {
                         return true;
                     }
                 }
@@ -172,7 +172,7 @@ function fuzz(options) {
                         const smallFixResult = linter.verifyAndFix(reducedText, smallConfig);
 
                         return smallFixResult.fixed && smallFixResult.messages.length === 1 && smallFixResult.messages[0].fatal;
-                    } catch (_) {
+                    } catch {
                         return false;
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ function getCacheFile(cacheFile, cwd) {`
`403`	`403`
`404`	`404`	`try {`
`405`	`405`	`fileStats = fs.lstatSync(resolvedCacheFile);`
`406`		`- } catch (ex) {`
	`406`	`+ } catch {`
`407`	`407`	`fileStats = null;`
`408`	`408`	`}`
`409`	`409`
`@@ -991,7 +991,7 @@ class CLIEngine {`
`991`	`991`	`const npmFormat = naming.normalizePackageName(normalizedFormatName, "eslint-formatter");`
`992`	`992`
`993`	`993`	`formatterPath = ModuleResolver.resolve(npmFormat, path.join(cwd, "__placeholder__.js"));`
`994`		`- } catch (e) {`
	`994`	`+ } catch {`
`995`	`995`	`formatterPath = path.resolve(__dirname, "formatters", normalizedFormatName);`
`996`	`996`	`}`
`997`	`997`	`}`
Original file line number	Diff line number	Diff line change
`@@ -517,7 +517,7 @@ class ConfigArrayFactory {`
`517`	`517`	`try {`
`518`	`518`	`loadPackageJSONConfigFile(filePath);`
`519`	`519`	`return filePath;`
`520`		`- } catch (error) { /* ignore */ }`
	`520`	`+ } catch { /* ignore */ }`
`521`	`521`	`} else {`
`522`	`522`	`return filePath;`
`523`	`523`	`}`
Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ function getLocalESLintVersion() {`
`350`	`350`	`const eslint = require(eslintPath);`
`351`	`351`
`352`	`352`	`return eslint.linter.version \|\| null;`
`353`		`- } catch (_err) {`
	`353`	`+ } catch {`
`354`	`354`	`return null;`
`355`	`355`	`}`
`356`	`356`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ module.exports = class ConfigCommentParser {`
`78`	`78`	`config: items`
`79`	`79`	`};`
`80`	`80`	`}`
`81`		`- } catch (ex) {`
	`81`	`+ } catch {`
`82`	`82`
`83`	`83`	`debug("Levn parsing failed; falling back to manual parsing.");`
`84`	`84`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ const collector = new (class {`
`35`	`35`	`try {`
`36`	`36`	`this._source = regexpStr;`
`37`	`37`	`this._validator.validatePattern(regexpStr); // Call onCharacter hook`
`38`		`- } catch (err) {`
	`38`	`+ } catch {`
`39`	`39`
`40`	`40`	`// Ignore syntax errors in RegExp.`
`41`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ module.exports = {`
`93`	`93`	`try {`
`94`	`94`	`validator.validateFlags(flags);`
`95`	`95`	`return null;`
`96`		`- } catch (err) {`
	`96`	`+ } catch {`
`97`	`97`	return `Invalid flags supplied to RegExp constructor '${flags}'`;
`98`	`98`	`}`
`99`	`99`	`}`