Update: make isSpaceBetweenTokens() ignore newline in comments (#12407)

yeonjuan · platinumazure · commit 2d6e345e3c26 · 2019-10-19T21:34:00.000-05:00
diff --git a/lib/source-code/source-code.js b/lib/source-code/source-code.js
@@ -423,7 +423,7 @@ class SourceCode extends TokenStore {
     isSpaceBetweenTokens(first, second) {
         const text = this.text.slice(first.range[1], second.range[0]);
 
-        return /\s/u.test(text.replace(/\/\*.*?\*\//gu, ""));
+        return /\s/u.test(text.replace(/\/\*.*?\*\//gus, ""));
     }
 
     /**
diff --git a/tests/lib/source-code/source-code.js b/tests/lib/source-code/source-code.js
@@ -1796,6 +1796,7 @@ describe("SourceCode", () => {
             ["let  foo = bar;", true],
             ["let /**/ foo = bar;", true],
             ["let/**/foo = bar;", false],
+            ["let/*\n*/foo = bar", false],
             ["a+b", false],
             ["a/**/+b", false],
             ["a/* */+b", false],

Original file line number	Diff line number	Diff line change
`@@ -423,7 +423,7 @@ class SourceCode extends TokenStore {`
`423`	`423`	`isSpaceBetweenTokens(first, second) {`
`424`	`424`	`const text = this.text.slice(first.range[1], second.range[0]);`
`425`	`425`
`426`		`- return /\s/u.test(text.replace(/\/\.?\*\//gu, ""));`
	`426`	`+ return /\s/u.test(text.replace(/\/\.?\*\//gus, ""));`
`427`	`427`	`}`
`428`	`428`
`429`	`429`	`/**`