fix: fix RuleContext type (#19417)

fasttime · web-flow · commit 274f054f19f5 · 2025-02-11T12:07:23.000-05:00
diff --git a/lib/types/index.d.ts b/lib/types/index.d.ts
@@ -34,7 +34,8 @@ import type {
     TraversalStep,
     LanguageOptions as GenericLanguageOptions,
     RuleDefinition,
-    RuleContext as CoreRuleContext
+    RuleContext as CoreRuleContext,
+    RuleContextTypeOptions
 } from "@eslint/core";
 import { JSONSchema4 } from "json-schema";
 import { LegacyESLint } from "./use-at-your-own-risk.js";
@@ -800,7 +801,10 @@ export namespace Rule {
         hasSuggestions?: boolean | undefined;
     }
 
-    interface RuleContext extends CoreRuleContext {
+    interface RuleContext extends CoreRuleContext<RuleContextTypeOptions & {
+        LangOptions: Linter.LanguageOptions;
+        Code: SourceCode;
+        Node: ESTree.Node; }> {
         // report(descriptor: ReportDescriptor): void;
     }
 
diff --git a/tests/lib/types/types.test.ts b/tests/lib/types/types.test.ts
@@ -436,7 +436,7 @@ rule = {
 };
 
 rule = {
-    create(context) {
+    create(context: Rule.RuleContext) {
         context.getAncestors();
 
         context.getDeclaredVariables(AST);
@@ -453,9 +453,14 @@ rule = {
 
         context.getCwd();
 
+        context.languageOptions;
+        context.languageOptions.ecmaVersion satisfies Linter.LanguageOptions["ecmaVersion"];
+
         context.sourceCode;
+        context.sourceCode.getLocFromIndex(42);
 
         context.getSourceCode();
+        context.getSourceCode().getLocFromIndex(42);
 
         context.getScope();
 
@@ -467,6 +472,9 @@ rule = {
 
         context.markVariableAsUsed("foo");
 
+        // @ts-expect-error wrong `node` type
+        context.report({ message: "foo", node: {} });
+
         context.report({ message: "foo", node: AST });
         context.report({ message: "foo", loc: { start: {line: 0, column: 0}, end: { line: 1, column: 1 } } });
         context.report({ message: "foo", node: AST, data: { foo: "bar" } });
