fix: improve message for no-console suggestions (#19483)

fasttime · web-flow · commit 19c0127e79c3 · 2025-03-06T12:47:18.000+01:00
diff --git a/lib/rules/no-console.js b/lib/rules/no-console.js
@@ -50,7 +50,8 @@ module.exports = {
         messages: {
             unexpected: "Unexpected console statement.",
             limited: "Unexpected console statement. Only these console methods are allowed: {{ allowed }}.",
-            removeConsole: "Remove the console.{{ propertyName }}()."
+            removeConsole: "Remove the console.{{ propertyName }}().",
+            removeMethodCall: "Remove the console method call."
         }
     },
 
@@ -165,22 +166,29 @@ module.exports = {
         function report(reference) {
             const node = reference.identifier.parent;
 
-            const propertyName = astUtils.getStaticPropertyName(node);
+            const suggest = [];
+
+            if (canProvideSuggestions(node)) {
+                const suggestion = {
+                    fix(fixer) {
+                        return fixer.remove(node.parent.parent);
+                    }
+                };
 
+                if (node.computed) {
+                    suggestion.messageId = "removeMethodCall";
+                } else {
+                    suggestion.messageId = "removeConsole";
+                    suggestion.data = { propertyName: node.property.name };
+                }
+                suggest.push(suggestion);
+            }
             context.report({
                 node,
                 loc: node.loc,
                 messageId: allowed.length ? "limited" : "unexpected",
                 data: { allowed: allowed.join(", ") },
-                suggest: canProvideSuggestions(node)
-                    ? [{
-                        messageId: "removeConsole",
-                        data: { propertyName },
-                        fix(fixer) {
-                            return fixer.remove(node.parent.parent);
-                        }
-                    }]
-                    : []
+                suggest
             });
         }
 
diff --git a/tests/lib/rules/no-console.js b/tests/lib/rules/no-console.js
@@ -426,6 +426,28 @@ ruleTester.run("no-console", rule, {
                 }]
             }]
         },
+        {
+            code: "console[foo](bar)",
+            errors: [{
+                messageId: "unexpected",
+                type: "MemberExpression",
+                suggestions: [{
+                    messageId: "removeMethodCall",
+                    output: ""
+                }]
+            }]
+        },
+        {
+            code: "console[0](foo)",
+            errors: [{
+                messageId: "unexpected",
+                type: "MemberExpression",
+                suggestions: [{
+                    messageId: "removeMethodCall",
+                    output: ""
+                }]
+            }]
+        },
 
         // In case that implicit global variable of 'console' exists
         {
