feat: account for sourceType: "commonjs" in the strict rule (#16308)

mdjermanovic · web-flow · commit 1729f9ea4d7b · 2022-09-16T23:49:40.000+02:00
Fixes #16304
diff --git a/lib/rules/strict.js b/lib/rules/strict.js
@@ -105,7 +105,7 @@ module.exports = {
         if (ecmaFeatures.impliedStrict) {
             mode = "implied";
         } else if (mode === "safe") {
-            mode = ecmaFeatures.globalReturn ? "global" : "function";
+            mode = ecmaFeatures.globalReturn || context.languageOptions.sourceType === "commonjs" ? "global" : "function";
         }
 
         /**
diff --git a/tests/lib/rules/strict.js b/tests/lib/rules/strict.js
@@ -10,7 +10,8 @@
 //------------------------------------------------------------------------------
 
 const rule = require("../../../lib/rules/strict"),
-    { RuleTester } = require("../../../lib/rule-tester");
+    { RuleTester } = require("../../../lib/rule-tester"),
+    FlatRuleTester = require("../../../lib/rule-tester/flat-rule-tester");
 
 //------------------------------------------------------------------------------
 // Tests
@@ -659,3 +660,46 @@ ruleTester.run("strict", rule, {
         }
     ]
 });
+
+const flatRuleTester = new FlatRuleTester();
+
+// TODO: merge these tests into `ruleTester.run` once we switch to FlatRuleTester (when FlatRuleTester becomes RuleTester).
+flatRuleTester.run("strict", rule, {
+    valid: [
+        {
+            code: "'use strict'; module.exports = function identity (value) { return value; }",
+            languageOptions: {
+                sourceType: "commonjs"
+            }
+        },
+        {
+            code: "'use strict'; module.exports = function identity (value) { return value; }",
+            options: ["safe"],
+            languageOptions: {
+                sourceType: "commonjs"
+            }
+        }
+    ],
+
+    invalid: [
+        {
+            code: "module.exports = function identity (value) { return value; }",
+            options: ["safe"],
+            languageOptions: {
+                sourceType: "commonjs"
+            },
+            errors: [
+                { messageId: "global", line: 1 }
+            ]
+        },
+        {
+            code: "module.exports = function identity (value) { return value; }",
+            languageOptions: {
+                sourceType: "commonjs"
+            },
+            errors: [
+                { messageId: "global", line: 1 }
+            ]
+        }
+    ]
+});

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ module.exports = {`
`105`	`105`	`if (ecmaFeatures.impliedStrict) {`
`106`	`106`	`mode = "implied";`
`107`	`107`	`} else if (mode === "safe") {`
`108`		`- mode = ecmaFeatures.globalReturn ? "global" : "function";`
	`108`	`+ mode = ecmaFeatures.globalReturn \|\| context.languageOptions.sourceType === "commonjs" ? "global" : "function";`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`/**`