Disable debugging configuration provider (microsoft#4022)

d3r3kk · web-flow · commit 92ec6be8e242 · 2019-01-16T16:50:23.000-08:00
* Disable debugging configuration provider for now.
diff --git a/news/1 Enhancements/3321.md b/news/1 Enhancements/3321.md
diff --git a/src/client/debugger/extension/configuration/debugConfigurationService.ts b/src/client/debugger/extension/configuration/debugConfigurationService.ts
@@ -21,14 +21,18 @@ export class PythonDebugConfigurationService implements IDebugConfigurationServi
     constructor(@inject(IDebugConfigurationResolver) @named('attach') private readonly attachResolver: IDebugConfigurationResolver<AttachRequestArguments>,
         @inject(IDebugConfigurationResolver) @named('launch') private readonly launchResolver: IDebugConfigurationResolver<LaunchRequestArguments>,
         @inject(IDebugConfigurationProviderFactory) private readonly providerFactory: IDebugConfigurationProviderFactory,
+        // tslint:disable-next-line:no-unused-variable
         @inject(IMultiStepInputFactory) private readonly multiStepFactory: IMultiStepInputFactory,
         @inject(IFileSystem) private readonly fs: IFileSystem) {
     }
     public async provideDebugConfigurations(folder: WorkspaceFolder | undefined, token?: CancellationToken): Promise<DebugConfiguration[] | undefined> {
         const config: Partial<DebugConfigurationArguments> = {};
         const state = { config, folder, token };
-        const multiStep = this.multiStepFactory.create<DebugConfigurationState>();
-        await multiStep.run((input, s) => this.pickDebugConfiguration(input, s), state);
+
+        // Disabled until configuration issues are addressed by VS Code. See #4007
+        // const multiStep = this.multiStepFactory.create<DebugConfigurationState>();
+        // await multiStep.run((input, s) => this.pickDebugConfiguration(input, s), state);
+
         if (Object.keys(state.config).length === 0) {
             return this.getDefaultDebugConfig();
         } else {
diff --git a/src/test/debugger/extension/configuration/debugConfigurationService.unit.test.ts b/src/test/debugger/extension/configuration/debugConfigurationService.unit.test.ts
@@ -114,7 +114,12 @@ suite('Debugging - Configuration Service', () => {
         multiStepInput.verifyAll();
         expect(Object.keys(state.config)).to.be.lengthOf(0);
     });
-    test('Ensure generated config is returned', async () => {
+    test('Ensure generated config is returned', async function () {
+        // Disable this test until this is resolved:
+        // Issue #4007: Disable debugging configuration provider temporarily
+        // tslint:disable-next-line:no-invalid-this
+        return this.skip();
+
         const expectedConfig = { yes: 'Updated' };
         const multiStepInput = {
             run: (_, state) => {
@@ -148,7 +153,10 @@ suite('Debugging - Configuration Service', () => {
         when(fs.readFile(jsFile)).thenResolve(JSON.stringify([expectedConfig]));
         const config = await configService.provideDebugConfigurations!({} as any);
 
-        multiStepFactory.verifyAll();
+        // Disable this check until this is resolved:
+        // Issue #4007: Disable debugging configuration provider temporarily
+        // multiStepFactory.verifyAll();
+
         expect(config).to.deep.equal([expectedConfig]);
     });
 });
