[manager] Remove backfill_avoidance dev_tweak.

ryzhyk · Karakatiza666 · commit a15f1794b954 · 2025-10-30T17:00:46.000Z
Allow changing stopped pipelines by default.

Signed-off-by: Leonid Ryzhyk &lt;ryzhyk@gmail.com&gt;
diff --git a/crates/dbsp/src/circuit/dbsp_handle.rs b/crates/dbsp/src/circuit/dbsp_handle.rs
@@ -309,10 +309,6 @@ pub struct DevTweaks {
     // adjust `server.rs` accordingly.
     pub stack_overflow_backtrace: bool,
 
-    /// Enable backfill avoidance feature.
-    // This flag is only used by the pipeline manager.
-    pub backfill_avoidance: bool,
-
     /// Controls the maximal number of records output by splitter operators
     /// (joins, distinct, aggregation, rolling window and group operators) at
     /// each step.
@@ -346,7 +342,6 @@ impl Default for DevTweaks {
             merger: MergerType::default(),
             storage_mb_max: None,
             stack_overflow_backtrace: false,
-            backfill_avoidance: false,
             splitter_chunk_size_records: 10_000,
             bloom_false_positive_rate: BLOOM_FILTER_FALSE_POSITIVE_RATE,
         }
diff --git a/crates/pipeline-manager/src/db/operations/pipeline.rs b/crates/pipeline-manager/src/db/operations/pipeline.rs
@@ -670,14 +670,6 @@ pub(crate) async fn update_pipeline(
         return Ok(current.version);
     }
 
-    // Check if backfill avoidance is enabled in dev_tweaks
-    let backfill_avoidance_enabled = current
-        .runtime_config
-        .get("dev_tweaks")
-        .and_then(|dev_tweaks| dev_tweaks.get("backfill_avoidance"))
-        .and_then(|backfill| backfill.as_bool())
-        .unwrap_or(false);
-
     // Certain edits are restricted to cleared storage
     if current.storage_status != StorageStatus::Cleared {
         let mut not_allowed = vec![];
@@ -712,28 +704,7 @@ pub(crate) async fn update_pipeline(
                 not_allowed.push("`runtime_config.resources.storage_mb_max`");
             }
         }
-        if !backfill_avoidance_enabled
-            && program_code
-                .as_ref()
-                .is_some_and(|v| *v != current.program_code)
-        {
-            not_allowed.push("`program_code`")
-        }
-        if !backfill_avoidance_enabled && udf_rust.as_ref().is_some_and(|v| *v != current.udf_rust)
-        {
-            not_allowed.push("`udf_rust`")
-        }
-        if !backfill_avoidance_enabled && udf_toml.as_ref().is_some_and(|v| *v != current.udf_toml)
-        {
-            not_allowed.push("`udf_toml`")
-        }
-        if !backfill_avoidance_enabled
-            && program_config
-                .as_ref()
-                .is_some_and(|v| *v != current.program_config)
-        {
-            not_allowed.push("`program_config`")
-        }
+
         if !not_allowed.is_empty() {
             return Err(DBError::EditRestrictedToClearedStorage {
                 not_allowed: not_allowed.iter_mut().map(|s| s.to_string()).collect(),
diff --git a/docs.feldera.com/docs/pipelines/modifying.md b/docs.feldera.com/docs/pipelines/modifying.md
@@ -378,11 +378,6 @@ pipeline = PipelineBuilder(
     TEST_CLIENT,
     pipeline_name,
     sql=gen_sql("2025-09-01", "2025-12-15"),
-    runtime_config=RuntimeConfig(
-        dev_tweaks={
-            "backfill_avoidance": True
-        },  # This should not be necessary once it is enabled by default.
-    ),
 ).create_or_replace()
 
 pipeline.start()
diff --git a/python/feldera/testutils.py b/python/feldera/testutils.py
@@ -256,7 +256,6 @@ def build_pipeline(
         compilation_profile=CompilationProfile.OPTIMIZED,
         runtime_config=RuntimeConfig(
             provisioning_timeout_secs=60,
-            dev_tweaks={"backfill_avoidance": True},
             resources=resources,
         ),
     ).create_or_replace()
diff --git a/python/tests/platform/test_bootstrapping.py b/python/tests/platform/test_bootstrapping.py
@@ -26,9 +26,6 @@ def test_bootstrap_enterprise(pipeline_name):
         sql=sql,
         runtime_config=RuntimeConfig(
             fault_tolerance_model=None,  # We will make manual checkpoints in this test.
-            dev_tweaks={
-                "backfill_avoidance": True
-            },  # This should not be necessary once it is enabled by default.
         ),
     ).create_or_replace()
 
@@ -281,9 +278,6 @@ def test_bootstrap_non_materialized_table_enterprise(pipeline_name):
         sql=sql,
         runtime_config=RuntimeConfig(
             fault_tolerance_model=None,  # We will make manual checkpoints in this test.
-            dev_tweaks={
-                "backfill_avoidance": True
-            },  # This should not be necessary once it is enabled by default.
         ),
     ).create_or_replace()
 
@@ -326,9 +320,6 @@ def test_bootstrap_table_lateness_enterprise(pipeline_name):
         sql=sql,
         runtime_config=RuntimeConfig(
             fault_tolerance_model=None,  # We will make manual checkpoints in this test.
-            dev_tweaks={
-                "backfill_avoidance": True
-            },  # This should not be necessary once it is enabled by default.
         ),
     ).create_or_replace()
 
@@ -372,9 +363,6 @@ def test_bootstrap_view_lateness_enterprise(pipeline_name):
         sql=sql,
         runtime_config=RuntimeConfig(
             fault_tolerance_model=None,  # We will make manual checkpoints in this test.
-            dev_tweaks={
-                "backfill_avoidance": True
-            },  # This should not be necessary once it is enabled by default.
         ),
     ).create_or_replace()
 
@@ -424,9 +412,6 @@ def gen_sql(connectors):
         sql=gen_sql(""),
         runtime_config=RuntimeConfig(
             fault_tolerance_model=None,  # We will make manual checkpoints in this test.
-            dev_tweaks={
-                "backfill_avoidance": True
-            },  # This should not be necessary once it is enabled by default.
         ),
     ).create_or_replace()
 
diff --git a/python/tests/platform/test_update_runtime.py b/python/tests/platform/test_update_runtime.py
@@ -28,7 +28,6 @@ def test_update_runtime(self):
             pipeline_name,
             sql=sql,
             runtime_config=RuntimeConfig(
-                dev_tweaks={"backfill_avoidance": True},
                 logging="debug",
             ),
         ).create_or_replace()
