fix: More precise timestamps (getsentry#425)

untitaker · web-flow · commit e28e211867f9 · 2019-07-11T15:03:20.000+02:00
* fix: More precise timestamps

* fix: Loosen assertions
diff --git a/sentry_sdk/serializer.py b/sentry_sdk/serializer.py
@@ -1,4 +1,5 @@
 import contextlib
+
 from datetime import datetime
 
 from sentry_sdk.utils import (
@@ -285,7 +286,7 @@ def _serialize_node_impl(self, obj, max_depth, max_breadth):
                 return obj
 
             if isinstance(obj, datetime):
-                return text_type(obj.strftime("%Y-%m-%dT%H:%M:%SZ"))
+                return text_type(obj.strftime("%Y-%m-%dT%H:%M:%S.%fZ"))
 
             if isinstance(obj, bytes):
                 obj = obj.decode("utf-8", "replace")
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -156,6 +156,7 @@ def inner(event):
             )
             _no_errors_in_semaphore_response(output)
             output.pop("_meta", None)
+            return output
 
     return inner
 
diff --git a/tests/test_serializer.py b/tests/test_serializer.py
@@ -0,0 +1,22 @@
+from datetime import datetime
+
+from hypothesis import given, assume, example
+import hypothesis.strategies as st
+
+from sentry_sdk.serializer import Serializer
+
+
+@given(dt=st.datetimes(timezones=st.just(None)))
+@example(dt=datetime(2001, 1, 1, 0, 0, 0, 999500))
+def test_datetime_precision(dt, assert_semaphore_acceptance):
+    assume(dt.year > 2000)
+    serializer = Serializer()
+
+    event = serializer.serialize_event({"timestamp": dt})
+    normalized = assert_semaphore_acceptance(event)
+
+    dt2 = datetime.utcfromtimestamp(normalized["timestamp"])
+
+    # Float glitches can happen, and more glitches can happen
+    # because we try to work around some float glitches in semaphore
+    assert (dt - dt2).total_seconds() < 1.0

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,7 @@ def inner(event):`
`156`	`156`	`)`
`157`	`157`	`_no_errors_in_semaphore_response(output)`
`158`	`158`	`output.pop("_meta", None)`
	`159`	`+ return output`
`159`	`160`
`160`	`161`	`return inner`
`161`	`162`