fix(serialize): Do not attach stacktrace with empty frames (getsentry#740)

untitaker · web-flow · commit b92b2b095e3b · 2020-06-29T14:55:56.000+02:00
* fix(serialize): Do not attach stacktrace with empty frames

* do not attach None
diff --git a/sentry_sdk/utils.py b/sentry_sdk/utils.py
@@ -458,18 +458,6 @@ def serialize_frame(frame, tb_lineno=None, with_locals=True):
     return rv
 
 
-def stacktrace_from_traceback(tb=None, with_locals=True):
-    # type: (Optional[TracebackType], bool) -> Dict[str, List[Dict[str, Any]]]
-    return {
-        "frames": [
-            serialize_frame(
-                tb.tb_frame, tb_lineno=tb.tb_lineno, with_locals=with_locals
-            )
-            for tb in iter_stacks(tb)
-        ]
-    }
-
-
 def current_stacktrace(with_locals=True):
     # type: (bool) -> Any
     __tracebackhide__ = True
@@ -515,14 +503,23 @@ def single_exception_from_error_tuple(
     else:
         with_locals = client_options["with_locals"]
 
-    return {
+    frames = [
+        serialize_frame(tb.tb_frame, tb_lineno=tb.tb_lineno, with_locals=with_locals)
+        for tb in iter_stacks(tb)
+    ]
+
+    rv = {
         "module": get_type_module(exc_type),
         "type": get_type_name(exc_type),
         "value": safe_str(exc_value),
         "mechanism": mechanism,
-        "stacktrace": stacktrace_from_traceback(tb, with_locals),
     }
 
+    if frames:
+        rv["stacktrace"] = {"frames": frames}
+
+    return rv
+
 
 HAS_CHAINED_EXCEPTIONS = hasattr(Exception, "__suppress_context__")
 
