Fix multiple **kwargs type hints (getsentry#967)

intgr · web-flow · commit b7816b0cc100 · 2021-01-11T10:50:53.000+01:00
A **kwargs argument should be hinted as `T`, instead of `Dict[str, T]`. The dict wrapping is already implied by the type system. See: https://mypy.readthedocs.io/en/stable/getting_started.html?highlight=kwargs#more-function-signatures
diff --git a/sentry_sdk/api.py b/sentry_sdk/api.py
@@ -70,7 +70,7 @@ def capture_event(
     event,  # type: Event
     hint=None,  # type: Optional[Hint]
     scope=None,  # type: Optional[Any]
-    **scope_args  # type: Dict[str, Any]
+    **scope_args  # type: Any
 ):
     # type: (...) -> Optional[str]
     return Hub.current.capture_event(event, hint, scope=scope, **scope_args)
@@ -81,7 +81,7 @@ def capture_message(
     message,  # type: str
     level=None,  # type: Optional[str]
     scope=None,  # type: Optional[Any]
-    **scope_args  # type: Dict[str, Any]
+    **scope_args  # type: Any
 ):
     # type: (...) -> Optional[str]
     return Hub.current.capture_message(message, level, scope=scope, **scope_args)
@@ -91,7 +91,7 @@ def capture_message(
 def capture_exception(
     error=None,  # type: Optional[Union[BaseException, ExcInfo]]
     scope=None,  # type: Optional[Any]
-    **scope_args  # type: Dict[str, Any]
+    **scope_args  # type: Any
 ):
     # type: (...) -> Optional[str]
     return Hub.current.capture_exception(error, scope=scope, **scope_args)
diff --git a/sentry_sdk/hub.py b/sentry_sdk/hub.py
@@ -311,7 +311,7 @@ def capture_event(
         event,  # type: Event
         hint=None,  # type: Optional[Hint]
         scope=None,  # type: Optional[Any]
-        **scope_args  # type: Dict[str, Any]
+        **scope_args  # type: Any
     ):
         # type: (...) -> Optional[str]
         """Captures an event. Alias of :py:meth:`sentry_sdk.Client.capture_event`."""
@@ -329,7 +329,7 @@ def capture_message(
         message,  # type: str
         level=None,  # type: Optional[str]
         scope=None,  # type: Optional[Any]
-        **scope_args  # type: Dict[str, Any]
+        **scope_args  # type: Any
     ):
         # type: (...) -> Optional[str]
         """Captures a message.  The message is just a string.  If no level
@@ -349,7 +349,7 @@ def capture_exception(
         self,
         error=None,  # type: Optional[Union[BaseException, ExcInfo]]
         scope=None,  # type: Optional[Any]
-        **scope_args  # type: Dict[str, Any]
+        **scope_args  # type: Any
     ):
         # type: (...) -> Optional[str]
         """Captures an exception.
diff --git a/sentry_sdk/integrations/chalice.py b/sentry_sdk/integrations/chalice.py
@@ -17,6 +17,7 @@
 
 if MYPY:
     from typing import Any
+    from typing import Dict
     from typing import TypeVar
     from typing import Callable
 
@@ -110,7 +111,7 @@ def setup_once():
             )
 
         def sentry_event_response(app, view_function, function_args):
-            # type: (Any, F, **Any) -> Any
+            # type: (Any, F, Dict[str, Any]) -> Any
             wrapped_view_function = _get_view_function_response(
                 app, view_function, function_args
             )

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`
`18`	`18`	`if MYPY:`
`19`	`19`	`from typing import Any`
	`20`	`+ from typing import Dict`
`20`	`21`	`from typing import TypeVar`
`21`	`22`	`from typing import Callable`
`22`	`23`
`@@ -110,7 +111,7 @@ def setup_once():`
`110`	`111`	`)`
`111`	`112`
`112`	`113`	`def sentry_event_response(app, view_function, function_args):`
`113`		`- # type: (Any, F, **Any) -> Any`
	`114`	`+ # type: (Any, F, Dict[str, Any]) -> Any`
`114`	`115`	`wrapped_view_function = _get_view_function_response(`
`115`	`116`	`app, view_function, function_args`
`116`	`117`	`)`