fix(serialization): Do not crash if tag is nan (getsentry#835)

untitaker · sentry-bot · web-flow · commit 86d14b0be0c6 · 2020-09-24T23:19:58.000+02:00
Co-authored-by: sentry-bot &lt;markus+ghbot@sentry.io&gt;
diff --git a/sentry_sdk/serializer.py b/sentry_sdk/serializer.py
@@ -1,4 +1,5 @@
 import sys
+import math
 
 from datetime import datetime
 
@@ -273,7 +274,12 @@ def _serialize_node_impl(
                     return _flatten_annotated(result)
 
         if obj is None or isinstance(obj, (bool, number_types)):
-            return obj if not should_repr_strings else safe_repr(obj)
+            if should_repr_strings or (
+                isinstance(obj, float) and (math.isinf(obj) or math.isnan(obj))
+            ):
+                return safe_repr(obj)
+            else:
+                return obj
 
         elif isinstance(obj, datetime):
             return (
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -15,6 +15,7 @@
     capture_exception,
     capture_event,
     start_transaction,
+    set_tag,
 )
 from sentry_sdk.integrations.executing import ExecutingIntegration
 from sentry_sdk.transport import Transport
@@ -463,6 +464,10 @@ def test_nan(sentry_init, capture_events):
     events = capture_events()
 
     try:
+        # should_repr_strings=False
+        set_tag("mynan", float("nan"))
+
+        # should_repr_strings=True
         nan = float("nan")  # noqa
         1 / 0
     except Exception:
@@ -472,6 +477,7 @@ def test_nan(sentry_init, capture_events):
     frames = event["exception"]["values"][0]["stacktrace"]["frames"]
     (frame,) = frames
     assert frame["vars"]["nan"] == "nan"
+    assert event["tags"]["mynan"] == "nan"
 
 
 def test_cyclic_frame_vars(sentry_init, capture_events):
