fix: Handle exc_info=0 (getsentry#905)

untitaker · sentry-bot · web-flow · commit 37ab6501d76a · 2020-11-02T20:13:20.000+01:00
Co-authored-by: sentry-bot &lt;markus+ghbot@sentry.io&gt;
diff --git a/sentry_sdk/integrations/logging.py b/sentry_sdk/integrations/logging.py
@@ -183,7 +183,12 @@ def _emit(self, record):
         client_options = hub.client.options
 
         # exc_info might be None or (None, None, None)
-        if record.exc_info is not None and record.exc_info[0] is not None:
+        #
+        # exc_info may also be any falsy value due to Python stdlib being
+        # liberal with what it receives and Celery's billiard being "liberal"
+        # with what it sends. See
+        # https://github.com/getsentry/sentry-python/issues/904
+        if record.exc_info and record.exc_info[0] is not None:
             event, hint = event_from_exception(
                 record.exc_info,
                 client_options=client_options,
diff --git a/tests/integrations/logging/test_logging.py b/tests/integrations/logging/test_logging.py
@@ -30,12 +30,15 @@ def test_logging_works_with_many_loggers(sentry_init, capture_events, logger):
 
 
 @pytest.mark.parametrize("integrations", [None, [], [LoggingIntegration()]])
-def test_logging_defaults(integrations, sentry_init, capture_events):
+@pytest.mark.parametrize(
+    "kwargs", [{"exc_info": None}, {}, {"exc_info": 0}, {"exc_info": False}]
+)
+def test_logging_defaults(integrations, sentry_init, capture_events, kwargs):
     sentry_init(integrations=integrations)
     events = capture_events()
 
     logger.info("bread")
-    logger.critical("LOL")
+    logger.critical("LOL", **kwargs)
     (event,) = events
 
     assert event["level"] == "fatal"
