Remove "Creator" aliases for builders

niklasf · niklasf · commit bbf718ec5289 · 2019-05-20T15:45:52.000+02:00
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -16,6 +16,8 @@ Changes:
   no legal en-passant capture exists.
 * Circular SVG arrows now have a `circle` CSS class.
 * Superfluous dashes (-) in EPDs are no longer treated as opcodes.
+* Removed `GameCreator`, `HeaderCreator` and `BoardCreator` aliases for
+  `{Game,Headers,Board}Builder`.
 
 Bugfixes:
 
diff --git a/chess/pgn.py b/chess/pgn.py
@@ -1343,9 +1343,3 @@ def skip_game(handle: TextIO) -> bool:
     Skip a game. Returns ``True`` if a game was found and skipped.
     """
     return bool(read_game(handle, Visitor=SkipVisitor))
-
-
-# TODO: Remove aliases
-GameCreator = GameBuilder
-HeaderCreator = HeadersBuilder
-BoardCreator = BoardBuilder
diff --git a/test.py b/test.py
@@ -2342,7 +2342,7 @@ def result(self):
         self.assertEqual(trace, chess.pgn.read_game(pgn).accept(TraceVisitor()))
 
         pgn.seek(0)
-        self.assertEqual(chess.Board(trace[-1]), chess.pgn.read_game(pgn, Visitor=chess.pgn.BoardCreator))
+        self.assertEqual(chess.Board(trace[-1]), chess.pgn.read_game(pgn, Visitor=chess.pgn.BoardBuilder))
 
     def test_black_to_move(self):
         game = chess.pgn.Game()
@@ -2527,7 +2527,7 @@ def test_subgame(self):
         pgn = io.StringIO("1. d4 d5 (1... Nf6 2. c4 (2. Nf3 g6 3. g3))")
         game = chess.pgn.read_game(pgn)
         node = game.variations[0].variations[1]
-        subgame = node.accept_subgame(chess.pgn.GameCreator())
+        subgame = node.accept_subgame(chess.pgn.GameBuilder())
         self.assertEqual(subgame.headers["FEN"], "rnbqkb1r/pppppppp/5n2/8/3P4/8/PPP1PPPP/RNBQKBNR w KQkq - 1 2")
         self.assertEqual(subgame.variations[0].move, chess.Move.from_uci("c2c4"))
         self.assertEqual(subgame.variations[1].move, chess.Move.from_uci("g1f3"))
